Repository navigation
Advance incremental LDAP timestamps before calendar formatting - #293
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance incremental LDAP lower bounds in epoch seconds before formatting, rather than adding one to the
YYYYmmddHHMMSSdecimal representation. This correctly rolls over minutes, days, leap days, and years, and avoids stripping significant zero digits from Active Directory timestamps.Fixes #292.
Dedicated regressions assert the actual outgoing LDAP filters for minute/year/leap-day boundaries and zero seconds in both LDAP and AD formats. The full-update control remains unchanged. Current main (
d8004db9da172245cf678359d5460ce0eda5ce97) fails four tests and passes the full-update control.Validation:
git diff --checkpass.