Skip to content

Advance incremental LDAP timestamps before calendar formatting - #293

Open
vinsymoyya wants to merge 1 commit into
google:mainfrom
vinsymoyya:fix/ldap-incremental-calendar
Open

vinsymoyya wants to merge 1 commit into
google:mainfrom
vinsymoyya:fix/ldap-incremental-calendar

Conversation

@vinsymoyya

Copy link
Copy Markdown
Contributor

Advance incremental LDAP lower bounds in epoch seconds before formatting, rather than adding one to the YYYYmmddHHMMSS decimal representation. This correctly rolls over minutes, days, leap days, and years, and avoids stripping significant zero digits from Active Directory timestamps.

Fixes #292.

Dedicated regressions assert the actual outgoing LDAP filters for minute/year/leap-day boundaries and zero seconds in both LDAP and AD formats. The full-update control remains unchanged. Current main (d8004db9da172245cf678359d5460ce0eda5ce97) fails four tests and passes the full-update control.

Validation:

  • 116 affected Linux / Python 3.11 tests pass with real python-ldap installed, including the existing/new LDAP suites, maps, file formats, and file-cache tests.
  • Black 22.12.0 and git diff --check pass.
  • No live LDAP server integration was run locally. Hosted CI is separate from these local results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incremental LDAP filters corrupt timestamps at calendar boundaries

1 participant