Repository navigation
Validate configured LDAP UID attributes before transforming maps - #295
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the configured
ldap_uidattrinstead of always requiring a literaluid. Passwd, shadow, and SSH-key transformations already read the selected attribute, butGetUpdatesrejected valid custom-schema entries before transformation becauseessential_fieldsstill containeduid.Fixes #294.
Use the configured UID attribute in required-field lists while retaining
uidas the default and leaving the AD-specific required fields unchanged. Dedicated public-path regressions cover all three map types, missing configured fields, and the default-UID control.Validation:
d8004db9da172245cf678359d5460ce0eda5ce97).git diff --checkpass. Six warnings come from the existing deprecatedlogging.warnpath exercised by missing-field controls.