Repository navigation
Fix parsing of unquoted hash characters in CLI arguments - #730
Open
MateehUllah wants to merge 2 commits into
Open
MateehUllah wants to merge 2 commits into
MateehUllah wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #619
This PR fixes an issue where Python Fire incorrectly removes parts of command-line arguments containing unquoted
#characters.For example, passing
qgm#123previously resulted inqgm. With this change, the original argument is preserved.Changes
fire/parser.pyto detect unquoted hash characters using Python's tokenizer.fire/parser_test.pyto cover the affected cases.Testing
Added test cases covering:
qgm#123anda#b#c.#.The isolated parsing checks passed. The full test suite has not yet been run.
Files Changed
fire/parser.pyfire/parser_test.pyRelated Issue
Fixes #619