Repository navigation
Conversation
…l release Moves packages/google-storage-control from release-please-config.json into release-please-submodules.json so it opens its own standalone release PR.
…g Object Re-runs npm run compile-protos inside packages/google-storage-control/librarian.js after storage_control_utils.js renames message Object to message StorageObject in storage.proto so protos/protos.js does not shadow global Object.
…nd RapidCache APIs Removes skip_generate from google-storage-control in librarian.yaml, preserves sample fixtures and webpack.config.js in keep, and regenerates @google-cloud/storage-control with ViewObjectFullContext, UpdateManagedFolder, and RapidCache APIs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Rapid Cache and Object Full Context features to the @google-cloud/storage-control package, introducing new proto definitions, client methods, and generated samples. However, a critical issue was found in gapic_metadata.json where the primary StorageControl service was completely overwritten by the Storage service, which will break tooling and tracking expecting the control plane client mapping.
| "comment": "This file maps proto services/RPCs to the corresponding library clients/methods", | ||
| "language": "typescript", | ||
| "protoPackage": "google.storage.control.v2", | ||
| "protoPackage": "google.storage.v2", |
There was a problem hiding this comment.
The gapic_metadata.json file has been regenerated such that the primary service StorageControl (package google.storage.control.v2) has been completely overwritten by the Storage service (package google.storage.v2). Since @google-cloud/storage-control is primarily for the control plane (StorageControlClient), this metadata overwrite will break tooling, tracking, and dashboards that expect StorageControlClient mapping. Please check the generator configuration or build scripts to ensure that the primary service's metadata is preserved or that both services are correctly represented.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
Stacked on #9837 and #9838. Removes
skip_generatefromgoogle-storage-controlinlibrarian.yaml, preserves sample fixtures andwebpack.config.jsinkeep, and regenerates@google-cloud/storage-controlwithViewObjectFullContext,UpdateManagedFolder, andRapidCacheAPIs.