Repository navigation
Conversation
google-gax 1.x capped google-protobuf at 3.x, and the lockfile only had the source variant of 3.25.8. On the ubuntu-26.04 runner, the Ruby 3.2 job fails to compile it. Remove google-gax and wrapped_gax_test.rb, depend directly on grpc and googleapis-common-protos, and require the protobuf helpers the tests used to get from google-gax. google-protobuf now resolves to 4.36.2 with a precompiled x86_64-linux-gnu build for Ruby 3.2 through 4.0. Fixes googleapis#36685
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36685
google-cloud-errorsstill pulled the legacygoogle-gax ~> 1.8as a test dependency. That cappedgoogle-protobufat 3.x, and the lockfile only had the source variant of 3.25.8, so the Ruby 3.2 job compiled it and fails on theubuntu-26.04runner (details in the issue).Changes
google-gaxfrom the Gemfile and depend directly ongrpcandgoogleapis-common-protos, which the tests require.wrapped_gax_test.rb(see below).google/protobuf/well_known_typesandgoogle/rpc/error_details_pbin the test helper. google-gax used to load both implicitly.Gemfile.lock:google-protobufmoves to 4.36.2 with the precompiledx86_64-linux-gnubuild for Ruby 3.2 through 4.0.Why it's safe to delete
wrapped_gax_test.rbgoogle-gax is legacy. google-gax was the runtime for the first generation of generated Ruby clients. Its last release, 1.8.2, was on 2021-09-13. gapic-common replaced it, and every client generated in this repo today uses gapic-common. No gem in this repo depends on google-gax anymore.
What replaces it. Current generated clients rescue
GRPC::BadStatusand callGoogle::Cloud::Error.from_errordirectly, with noGaxErrorin between (example).Test plan
bundle exec rake teston Ruby 4.0.2 and 3.2.11: 88 runs, 0 failures, 0 errors. On Ruby 3.2, Bundler installs the precompiledgoogle-protobufbuild with no native compilation.bundle exec rubocop: no new offenses.CI (ubuntu-latest, 3.2, --test)check on this PR.