Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 91.47% 98.68% +7.21%
==========================================
Files 81 48 -33
Lines 5326 3354 -1972
Branches 973 619 -354
==========================================
- Hits 4872 3310 -1562
+ Misses 433 17 -416
- Partials 21 27 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… and config tests
…ervice tests to Foundry
… tests to Foundry
Port the unique cases of rewards.test.ts to legacySuite.t.sol, map the duplicates to the existing tests and delete the TS file. Move the shared deny, oracle, reclaim and accrue helpers into shared.t.sol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
packages/contractsandpackages/contracts-test: frozen contracts move unchanged into the newgraph-coreandgraph-tokenpackages (bytecode checked bypnpm check:bytecode), RewardsManager is ported to Solidity 0.8 in issuance and L2GNS and L2Curation in subgraph-service with storage layouts checked bypnpm check:storage, the tests move to Foundry, dead code is deleted, the verified mainnet sources are archived in the privatelegacypackage, and the Graph Studio billing contracts are imported unchanged as the privatebillingpackage. Each phase landed here as its own reviewed PR, following the design and plans in #1372.For the audit, the new code is the two port commits 6da4c4e (RewardsManager) and ea25620 (L2GNS, GNS, L2Curation, their storage, Multicall,
InitializableV3), read against thepre-port-0.7.6tag, and the billing import, where bcdafc0 is the original code at billing-contracts8b063dband 9667c7c only adaptspackage.jsonand scripts. The frozen moves are bytecode-identical, andpackages/legacy/verified/**is an archive of already-verified source that isn't compiled. The ports' accepted differences are arithmetic reverts becomingPanicinstead of SafeMath strings, the unused MathUtilsminandweightedAverageRoundingUpdeleted, and per-file compiler settings of 0.8.35 with 200 runs, no viaIR and cancun.Important
Merge with a merge commit, not a squash: the port and billing commits are what the audit covers, and
packages/legacy/README.mdcites a commit from this history.