Repository navigation
Update windows makefile and doc (vcpkg) - #81
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Architecture and configuration switches can reuse incompatible outputs, and DLL copying can prompt during unattended builds.
3 open issues
What changed in this PR
This PR updates the Windows NMAKE build to use vcpkg-managed dependencies and documents the corresponding setup.
Changes:
- Select dependency paths by target architecture and debug/release configuration.
- Update Boost linking and runtime DLL staging for shared libraries.
- Document vcpkg installation and x64/x86 build commands.
| File | Description |
|---|---|
win/makefile |
Adds architecture-aware vcpkg paths, shared Boost linking, and DLL copying. |
doc/book.xml |
Replaces legacy dependency instructions with vcpkg setup and build guidance. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.