[MagnusIntel]

Add the ability to select context when setting a breakpoint

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

4 open issues

• when clause string comparisons should quote the string literal (e.g. `debugType ==… · New
• when clause string comparisons should quote the string literal (e.g. `debugType ==… · New
• This always adds a threadId property for getFunctionBreakpointContexts even when… · New
• The error message is a bit ambiguous compared to similar flows (e.g. “Start a Simics Target Debug… · New

What changed in this PR

Adds a new VS Code command to create function breakpoints scoped to a selected debug context (core) and wires up adapter support for returning context/thread metadata used by the UI.

Changes:

• Add simics-target-debug.addFunctionBreakpointInContext command + menus and implement a Quick Pick flow to choose a context before entering a symbol.
• Extend the debug adapter to serve getFunctionBreakpointContexts (incl. optional threadId) and update tests accordingly.
• Add parsing/validation for explicitly scoped function breakpoints using symbol @ contextId, with new unit tests and updated documentation.

File	Description
test/​symbolContexts.test.ts	Extends symbol-context tests to cover getFunctionBreakpointContexts and threadId propagation.
src/​test/​breakpointManager.test.ts	Adds coverage for scoped function breakpoint parsing and capability handling.
src/​tcfDebugSession.ts	Adds adapter command handling for getFunctionBreakpointContexts and returns optional threadId.
src/​extension.ts	Implements the new UI command that prompts for context + symbol and creates a function breakpoint.
src/​breakpointManager.ts	Parses symbol @ contextId and sets ContextIds with capability validation.
package.json	Registers the new command and surfaces it in the command palette, call stack context menu, and view title.
README.md	Documents the new command and the symbol @ contextId scoping syntax/behavior.

_{Review effort: Lite}

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• when clause string comparisons should quote string literals (e.g., `view ==… · New
• The reserved delimiter " @ " is now a cross-file contract (constructed in extension.ts, parsed… · New
• Object.hasOwn is relatively new compared to Object.prototype.hasOwnProperty.call(...). If the… · New

4 resolved since last review

• when clause string comparisons should quote the string literal (e.g. `debugType ==…
• when clause string comparisons should quote the string literal (e.g. `debugType ==…
• This always adds a threadId property for getFunctionBreakpointContexts even when…
• The error message is a bit ambiguous compared to similar flows (e.g. “Start a Simics Target Debug…

_{Review effort: Lite}

[aragners]

Good enough for now.
Have some potential improvements, selecting multiple contexts etc, but can be added later.