Repository navigation
fix(ci): daily-update Verify slack for history_total vs stars (2 → 5) - #15
Merged
Merged
Conversation
…rify GitHub's stargazers/history can lag the live count by a few stars. The 2026-11-01 daily-update failed Verify on affaan-m/ECC (diff 3, slack 2) and skipped the data push. Keep the integrity check; raise slack 2 → 5. Co-authored-by: PaintingCoder <jammyfu@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily-update run 41235403615 (schedule, Beijing ~03:41 on 2026-11-01) fetched OK, then failed Verify:
Commit/push was skipped because
|history_total - stars|was 3 while the allowed slack was 2.stargazers/historyweekly buckets can lag the livestargazers_countby a few stars (un-stars, same-day stars, UTC vs week boundaries). The integrity check stays. The allowed absolute delta is now 5 (HISTORY_TOTAL_STAR_SLACKintools/risers_core.py). A 3-star gap is accepted; a gap larger than 5 still fails.Changed files
tools/risers_core.py— named constantHISTORY_TOTAL_STAR_SLACK = 5and helperhistory_total_within_slacktests/test_repo.py— Verify assertion uses the helper (no longer a hardcoded<= 2)tests/test_core.py— regression: delta 3 and 5 pass, delta 6 fails; the old<= 2assertion cannot come backdocs/DAILY_UPDATE.md— documents the slack and the 2026-11-01 failuredocs/project-governance/DECISIONS.md,CHANGELOG.md,WORKLOG.md— decision and recordCURRENT_PLAN.md,TODO_BACKLOG.md— PLAN-002 and follow-up to confirm the next daily runNo ranking logic, secrets, or generated
README*/data//latest//rankings/files were changed.How to re-run / verify
Local result: 202 tests OK, all verification commands passed.
After this is merged to
main, the next scheduleddaily-update(or aworkflow_dispatch) will pick up the new slack and can commit the star data. Do not merge from this PR without owner review.Checklist
data/projects.json,data/categories.json,docs/,tools/), not generated filespython3 tools/verify.pypasses