Repository navigation
Conversation
Read maven-metadata.xml from the place the extractor jars come from (releases.jfrog.io, or the remote repository of JFROG_CLI_RELEASES_REPO / JFROG_CLI_EXTRACTORS_REMOTE) and give the list of versions to build-info-go. Skip a version that JFrog Curation blocks. - ListMavenExtractorVersions and ListGradleExtractorVersions, with the pin variables JFROG_CLI_MAVEN_EXTRACTOR_VERSION and JFROG_CLI_GRADLE_EXTRACTOR_VERSION. - DownloadDependency reports a Curation block as biutils.ErrBlockedByCuration, and copies the downloaded file into place atomically. - The list of versions and the blocked versions are saved for one hour.
…sion selection Temporary, until the build-info-go change is merged: then bump to the merged commit.
C1-C11 Add tests: non-Curation errors are not remembered as blocked, second Curation check on the download, Range header, cache pruning and merging, case of the Curation type, blocked beats verified, file mode of the cache files, Gradle list path, Verify flag, malformed metadata, copyFileAtomically C12 Rename serverReachable to listIsCurrent C13 versionsCachePath uses urlCachePath Use the build-info-go commit with the matching tests
K1 Test that a slow probe times out K2 A lost rename of the jar to a jar that already exists is not an error (Windows) K3 Test that the list functions are silent and the deprecated warning is printed once K4 Test DownloadDependency with an archive K5 checkRecentlyBlocked takes the URL that the caller resolved K6 Note that a lost cache entry is accepted Use the build-info-go commit with the matching fixes
udaykb2
approved these changes
Nov 18, 2026
… no new failure The error of a lookup that is skipped because of the failure window wraps ErrLookupNotRepeated, so build-info-go logs it at Debug level. Use the build-info-go commit with that change.
itsmeleela
reviewed
Nov 18, 2026
itsmeleela
left a comment
Collaborator
There was a problem hiding this comment.
Review of RTECO-2751. Blocking item: this pins an unmerged build-info-go commit and is not a draft.
… is older than the default
After a crash, an empty or partial jar must not stay under the final name. Use the build-info-go commit with the same change.
build-info-go now keeps an existing file when the rename is refused (Windows), so the copy of this logic and its tests are removed.
…extractor version When it is false, the CLI makes no lookup of versions and no request to check a downloaded jar, and uses the bundled version, as before the newest version was chosen at run time. A pinned version is still used. A value that is not true or false fails the command.
…wnload error message The request for the reason of a 403 reads at most 64 KiB, and stops after the verify timeout, so a server that ignores the Range header cannot make the CLI read a whole jar or wait for ever. The message of a failed download had two verbs and one argument.
…tion The CI lint rule forcetypeassert refused w.(http.Flusher). http.NewResponseController does the same flush.
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

RTECO-2751
Depends on jfrog/build-info-go#440. This PR needs a
go.modbump to the build-info-go commit of that PR after it is merged. It stays a draft until then.What this adds
If JFrog Curation blocks the fixed extractor version in a user's remote repository,
jf mvnandjf gradlefail until a new CLI is released. This PR finds the newest allowed version at run time.ListMavenExtractorVersionsandListGradleExtractorVersionsreadmaven-metadata.xmlfrom the same place as the extractor jar. That place is releases.jfrog.io, or the remote repository ofJFROG_CLI_RELEASES_REPOor the deprecatedJFROG_CLI_EXTRACTORS_REMOTE. Both variables keep their own URL layout. The Gradle lookup stays in the major line that the Gradle version needs.DownloadDependencyreports a Curation block asbiutils.ErrBlockedByCuration. A 403 counts as a Curation block only if the body has"type": "Curation"or the Curation text. Any other 403 (for example a missing permission) is not retried. A download copies the file into place atomically.JFROG_CLI_MAVEN_EXTRACTOR_VERSIONandJFROG_CLI_GRADLE_EXTRACTOR_VERSION. A pin skips the lookup. The Gradle pin must be in the major line that the Gradle version needs.<dependencies>/extractor-versions/. The files have owner-only permissions. Damaged files are ignored. A failed lookup uses an old saved list. A run with a saved list sends no request.DownloadDependencyis also used byjfrog-cli-security. For a normal download nothing changes. A Curation 403 now returns an error that wrapsErrBlockedByCuration, and the original text stays in the message.Tests
go test -race ./utils/dependencies/ ./utils/coreutils/passes.gofmtandgo vetare clean.jf mvn(Maven 3.10) andjf gradle(Gradle 8.7). Both were built from this change together with the build-info-go and jfrog-cli-artifactory PRs. Cases: direct from releases.jfrog.io, through a remote repository with Curation, the deprecated variable, blocked versions, pins, a server that is down, a 502 on the newest version, and six parallel runs.