Repository navigation
Add RoleDefinition.find_all to list role definitions - #124
Merged
Merged
Conversation
Wraps GET /1.0/kb/security/roles, available in Kill Bill 0.25+ (killbill/killbill#2250). Needed by Kaui to list and edit roles (killbill/killbill-admin-ui#161).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KillBillClient::Model::RoleDefinition.find_all, which callsGET /1.0/kb/security/roles(Kill Bill 0.25+, Add API to List All Available Role Definitions killbill#2250)Needed by Kaui to list and edit roles (killbill/killbill-admin-ui#161).
Testing
bundle exec rspec spec/killbill_client(excludingremote/): 54 examples, 0 failures[{"role": ..., "permissions": [...]}], which the model parses