Repository navigation
Remove unnecessary testing and static analysis dependencies - #57
Conversation
There was a problem hiding this comment.
馃煝 Approval recommended
The reviewed dependency cleanup is complete with no unresolved blocking issues.
Pull request overview
Removes redundant development dependencies and the unused PHPStan plugin configuration from composer.json.
Changes:
- Removes Pest, PHP CS Fixer, PHPStan, and the PHPStan extension installer.
- Removes the PHPStan plugin allowlist entry.
File summaries
| File | Description |
|---|---|
composer.json |
Simplifies development dependencies and plugin configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mychidarko
left a comment
mychidarko
left a comment
There was a problem hiding this comment.
Tests only passed here because leafs/billing v5.0 wrongly listed pestphp/pest and php-cs-fixer in its require. billing v5.0.1 dropped them, so a fresh install of this branch no longer gets Pest or php-cs-fixer, and alchemy test / alchemy lint need both (alchemy itself doesn't pull them in). Please keep pestphp/pest and friendsofphp/php-cs-fixer in require-dev. Dropping phpstan/phpstan is fine since rector requires it, but if you remove phpstan/extension-installer, check that alchemy analyse still picks up its config.
mychidarko
left a comment
mychidarko
left a comment
There was a problem hiding this comment.
Correction to my earlier review: Alchemy v5 installs its tools lazily (Pest on the first composer run test, PHPStan on the first analyse), so these don't need to be in require-dev. Approving. The only failing check is lint, which is the checkout bug fixed in #58; a rebase on v5.x should clear it.
Remove Pest, PHP-CS-Fixer, and PHPStan from composer.json to streamline the development environment. These tools are no longer required for the project's current workflow.
5c37a0f to
e0e6157
Compare
What kind of change does this PR introduce? (pls check at least one)
pestphp/pest,friendsofphp/php-cs-fixerare already required byleafs/billing.phpstan/phpstanis required byrector/rectorandphpstan/extension-installerwas not being usedDescription
This pull request simplifies the development dependencies in the
composer.jsonfile by removing several tools related to static analysis and code style, as well as updating the plugin configuration.Development dependency cleanup:
phpstan/phpstanandphpstan/extension-installerfrom therequire-devsection, which means PHPStan static analysis will no longer be available as a development dependency.friendsofphp/php-cs-fixerfrom therequire-devsection, so PHP CS Fixer for code style checks is no longer included.pestphp/pestfrom therequire-devsection, which means the Pest testing framework is no longer a development dependency.Configuration update:
allow-pluginssection to removephpstan/extension-installer, reflecting the removal of PHPStan-related dependencies.Does this PR introduce a breaking change? (check one)