Repository navigation
Escape untrusted strings in LNURL-auth logs - #1184
Open
benthecarman wants to merge 2 commits into
Open
benthecarman wants to merge 2 commits into
benthecarman wants to merge 2 commits into
Conversation
The LNURL-auth flow logged the decoded callback URL, its tag query parameter, and the server-supplied failure reason verbatim. All three are controlled by whoever produced the LNURL or runs the auth server, so embedded newlines or terminal escape sequences could forge log lines or tamper with an operator's terminal. Render these values through PrintableString, which replaces control characters, as is already done for other untrusted strings. This was found by Project Loupe. This change was made with the help of Claude Code.
|
I've assigned @tnull as a reviewer! |
The full LNURL-auth callback URL was written to the debug log. It carries the k1 challenge and may also include userinfo credentials or service-specific session parameters, which then end up in log files or custom log sinks. Log just the domain instead, which is all that's needed to tell which service the node is authenticating with. This was found by Project Loupe. This change was made with the help of Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LNURL-auth flow logged the decoded callback URL, its tag query parameter, and the server-supplied failure reason verbatim. All three are controlled by whoever produced the LNURL or runs the auth server, so embedded newlines or terminal escape sequences could forge log lines or tamper with an operator's terminal.
Render these values through PrintableString, which replaces control characters, as is already done for other untrusted strings.
This was found by Project Loupe.