Repository navigation
Widen supported rusqlite version range - #1187
Merged
Merged
Conversation
Requiring rusqlite 0.31 prevents applications from combining LDK Node with dependencies that need newer SQLite bindings, even when the persistence APIs remain compatible. Allow releases from 0.31 through 0.39 while preserving Rust 1.85 support and existing persistence behavior. Exclude 0.40 because its first two releases require a newer compiler. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @benthecarman as a reviewer! |
Contributor
|
omg i didn't know this was possible! |
Root builds remain on rusqlite 0.31 because historical Node releases are required by upgrade tests. This can conceal incompatibilities with newer releases allowed by the library. Test downstream persistence with exact minimum and maximum versions on Rust 1.85. Keep the fixture independent of the root test graph so both endpoints are actually exercised. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-10-widen-rusqlite
branch
from
October 20, 2026 22:19
4be42e2 to
0d96cbe
Compare
benthecarman
approved these changes
Oct 20, 2026
3 tasks
thesimplekid
added a commit
to thesimplekid/cdk
that referenced
this pull request
Oct 21, 2026
Accept rusqlite >=0.31.0, <0.40.0 to match LDK Node and allow downstream applications to select a compatible SQLite dependency. Following lightningdevkit/ldk-node#1187 Add an independent compatibility fixture with mint, wallet, and persistence tests. Build both endpoints on Rust 1.85 with Nix and Crane in required CI, using committed lockfiles and vendored dependencies. This avoids the root workspace dependency on LDK Node 0.7 that constrains rusqlite to 0.31. Validated all 133 tests against each minor release from 0.31.0 to 0.39.0 on Rust 1.85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds notoriously fail if multiple
rusqliteversions are present in any given project (see rusqlite/rusqlite#1727). Here we widen (and test) our supportedrusqliteversion range, leaving picking a version compatible with other crates tocargo.(cc @thesimplekid @notmandatory @oleonardolima @dpc)