Repository navigation
[Next] Improved generation of themes - #557
Open
WerIstLuka wants to merge 14 commits into
Open
WerIstLuka wants to merge 14 commits into
WerIstLuka wants to merge 14 commits into
Conversation
* fixed scrollbar overwriting window borders on wayland * only apply the border to scrollbars inside of a terminal * moved the terminal borders and made them more specific
clefebvre
changed the title
Member
|
Wow, there's a lot to unpack here. I pushed a branch with some of the commits and additional fixes on https://github.com/linuxmint/mint-themes/commits/improved-build/. build-themes.py is only a refactor with factorized functions, I didn't keep that. The threading looks good but I added a pool size to threading. These are internal so no urgency to get them in for Mint 27. We'll have another look in the next dev cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what I did:
"%s" % varnotation withf"{var}"(f-strings)I verified multiple times that the resulting files are equal
The changes in src/Mint-Y/variations also happened on an unmodified fork so someone probably just forgot to run it
What about Mint-L? I heard that it won't stick around for long so I wanna know if it wouldn't be an awful decision doing the same to Mint-L
The speedups are quite big for me
Tested on: Ryzen 5 9600x, 48gb ddr5 5600mt/s dual channel, pcie gen4 nvme, Linux Mint 22.3