Repository navigation
Conversation
check_mesa_vendor() only matched "Tungsten Graphics, Inc", "VMware, Inc." and "Mesa Project". Mesa 20.3 and 22.3 report GL_VENDOR as "Mesa/X.org", and Mesa 25.0+ report plain "Mesa", so on those versions the vendor is never recognized, the llvmpipe/softpipe/swrast architecture checks in mesa_architectures are never reached, and meta_renderer_is_hardware_accelerated() falls through to COGL_GPU_INFO_ARCHITECTURE_UNKNOWN, which it treats as hardware accelerated. As a result, on llvmpipe (VMs without 3D, systems without a working GPU driver), Cinnamon's software-rendering fallback never engages: software_rendering stays false, animations stay enabled, and the "check your video drivers" notification never shows, even though rendering is fully done in software. Fixes: linuxmint#879 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for the contribution! I went through the change: it's correct and safe. The vendor is only used to pick the architecture table, so hardware Mesa drivers that report "Mesa" are still treated as accelerated. The two strings also cover every Mesa release I could check ("Mesa/X.org" in 20.3 and 22.3, "Mesa" from 24.0 to 26.2). As I wrote in #879, though, I'd still prefer option 2, checking only About linuxmint/cinnamon#14058: I had suggested the same link there, through the startup animation, which only runs when |
Summary
check_mesa_vendor()only matched"Tungsten Graphics, Inc","VMware, Inc."and"Mesa Project". Mesa 20.3/22.3 reportGL_VENDORas"Mesa/X.org", and Mesa 25.0+ report plain"Mesa", so on those versions the vendor is never recognized.mesa_architecturesare only reached after the vendor matches,meta_renderer_is_hardware_accelerated()falls through toCOGL_GPU_INFO_ARCHITECTURE_UNKNOWN, which it treats as hardware-accelerated — so on llvmpipe (VMs without 3D, systems without a working GPU driver) Cinnamon's software-rendering fallback never engages:software_renderingstaysfalse, animations stay enabled, and the "check your video drivers" notification never shows, even though rendering is fully done in software.Fixes #879
Test plan
glxinfo -BshowsAccelerated: noand, after this change, Looking Glass reportsMeta.get_backend().is_rendering_hardware_accelerated()asfalseandsoftware_renderingastrue