Repository navigation
List the calls that reach an allowed state when the state is unknown - #413
Merged
CatarinaGamboa merged 1 commit intoOct 23, 2026
Merged
Conversation
2 tasks done
CatarinaGamboa
added this pull request to stack #415
October 23, 2026 16:59
When nothing is known about the receiver's state, the error lists the constructors and the calls, with the states they are made from, that lead to a state allowing the failing call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
force-pushed
the
feat/state-hints-dead-ends
branch
from
October 23, 2026 17:45
0cf5598 to
f34e6f6
Compare
CatarinaGamboa
force-pushed
the
feat/state-hints-unknown
branch
from
October 23, 2026 17:45
3af49f3 to
d1785aa
Compare
CatarinaGamboa
removed this pull request from stack #415
October 23, 2026 18:02
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 24, 2026
Stacked on #413. ## Description Building a state machine takes about 25 SMT checks for a small class, and each check creates its own Z3 context. The machine only depends on specifications, which are all registered in the first pass, so `TypeChecker` now builds it on the first state error and reuses it for every later error in the same checker. Finding the receiver's current states still runs at each error. Other options considered: - **Eagerly, after the first pass, for every class with `@StateSet`:** correct programs would pay the SMT cost too. Only worth it once something needs machines without an error, e.g. the fsm diagram. - **Once per run, cached in `Context`:** `Context` would depend on `state_machine`, which depends on `context` (a package cycle). The other way is a static cache that tracks when specifications change. Neither seemed worth it for the extra hits across classes. ## Cost Extra time of `TestExamples` on the 269 cases that exist on `main` (summed per case, one run each; `main` takes 80.3 s): - #413, without the cache: +29.5 s - with this PR: +10.6 s, spread over the 54 files with state errors ## Type of change - [x] Code refactoring ## Checklist - [x] `mvn test` passes locally 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 24, 2026
## Description #412, #413 and #414 were merged into their stacked base branches instead of `main`: once #411 was merged, their bases were never retargeted. Their code is only on `feat/state-hints-unknown`. This PR applies the three reviewed commits on top of `main`, unchanged: - Explain dead ends in failing state transitions (#412) - List the calls that reach an allowed state when the state is unknown (#413) - Build each class's state machine once per checker (#414) The hint and state machine files are identical to `feat/state-hints-unknown`. Rebase-merging keeps the three commits separate. ## Checklist - [x] `mvn test` passes locally on top of the current `main` (#408, #409) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #412.
Description
When nothing is known about the receiver's state (e.g. a parameter with no state refinement), the error used to say only that no state information is known. For classes with a state machine, it now lists the constructors and the calls that lead to a state allowing the failing call, each with the states it is called from.
Classes without a state machine keep the previous general hint.
Example
Type of change
Checklist
ErrorStateHintUnknownState.TestStateHintsalso checks that a class without@StateSetkeeps the general hint.mvn testpasses locally🤖 Generated with Claude Code