Repository navigation
Add --dump to discovery - #37
Merged
Merged
Conversation
Prints discovered orchestrators as JSON and exits.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the CLI-only discovery dump mode for one-shot inventory inspection.
No open issues 🎉
What changed in this PR
Adds CLI-only --dump mode to both discovery entry points, enabling one-shot inventory inspection without starting listeners or periodic refreshes, addressing issue #30.
Changes:
- Reuses discovery collection and HTTP response encoding to write a newline-terminated JSON array.
- Handles partial and total source failures, cancellation, and output errors, with diagnostics on stderr.
- Adds unit and binary integration coverage, documents exit behavior, and updates CLI help.
| File | Description |
|---|---|
docs/discovery.md |
Documents dump mode, output, and exit behavior. |
discovery/server.go |
Adds one-shot collection and shared response encoding. |
discovery/server_test.go |
Tests response parity, record preservation, timeouts, cancellation, and output errors. |
discovery/app.go |
Adds the flag, conflicting-flag validation, and cancellable stdout writes. |
discovery/app_test.go |
Tests source outcomes, advertising switches, and configuration precedence. |
cmd/livepeer/testdata/cli/discovery-help.golden |
Adds --dump to expected CLI help. |
cmd/livepeer/integration_test.go |
Tests both entry points, occupied ports, failures, and output cancellation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints discovered orchestrators as JSON and exits.
Fixes #30