Skip to content

Rename the samples workflow to run-samples.yml - #49

Merged
paolosalvatori merged 1 commit into
mainfrom
smf-995-rename-the-aks-samples-ci-workflow-to-run-samplesyml
Oct 28, 2026
Merged

paolosalvatori merged 1 commit into
mainfrom
smf-995-rename-the-aks-samples-ci-workflow-to-run-samplesyml

Conversation

@paolosalvatori

@paolosalvatori paolosalvatori commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The workflow that tests the samples of localstack-azure-samples is run-samples.yml, while the one that tests the samples of this repository is samples.yml.
This renames ours, so that both repositories use the same file name for the same pipeline, and links to it and commands that take its file name, such as gh workflow run run-samples.yml, work the same way in both.

Fixes SMF-995

Changes

  • .github/workflows/samples.yml becomes .github/workflows/run-samples.yml, with one line changed.
  • That line lists the files whose change runs every app: the cluster script, the end-to-end test and the workflow itself, which the setup job finds by its path. The path now reads .github/workflows/run-samples.yml; with the old one, a pull request that changes only the workflow would run no app.
  • The README's link to the workflow follows the new name.
  • The workflow keeps its name, Test samples on LocalStack for Azure, and its job names. GitHub tracks a workflow by its file path, so run-samples.yml is a new workflow record, and the runs before this change stay with the samples.yml one, under the same name.

Tests

  • The old and the new "Select the samples to run" step, run locally against this branch as a pull request runs them: both see .github/workflows/run-samples.yml and README.md change, the old step selects no app and the new one selects all 20.
  • shellcheck on that step, and the repository's pre-commit hooks (zizmor, gitleaks). actionlint runs in the "Lint GitHub Actions workflows" check of this pull request.
  • The workflow changed, so the CI of this pull request runs every app on Linux.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FvNuJK2RKgjS5PGMgTuSAF

localstack-azure-samples calls the workflow that tests its samples run-samples.yml, and this repository now uses the same file name for its own.
The workflow lists its own path among the files whose change runs every app, so that entry follows the new name: with the old one, a pull request that changes only the workflow would run no app.
The README's link to the workflow follows the new name too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FvNuJK2RKgjS5PGMgTuSAF
Copilot AI balanced review requested due to automatic review settings October 28, 2026 08:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the workflow rename and related reference updates.

No open issues 🎉

What changed in this PR

Renames the sample-testing workflow to run-samples.yml to match localstack-azure-samples, making workflow links and CLI commands consistent across both repositories.

Changes:

  • Updates the workflow’s shared-file filter so changes to its new path still trigger all 20 sample apps.
  • Updates the README link while preserving the workflow’s display name and job names.
File Description
README.md Points the workflow link to the renamed file.
.github/​workflows/​run-samples.yml Renames the workflow and updates its self-referencing change filter.

Review effort: Balanced

@paolosalvatori
paolosalvatori merged commit e9470ce into main Oct 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants