Repository navigation
Rename the samples workflow to run-samples.yml - #49
Merged
paolosalvatori merged 1 commit intoOct 28, 2026
Merged
paolosalvatori merged 1 commit into
paolosalvatori merged 1 commit into
Conversation
localstack-azure-samples calls the workflow that tests its samples run-samples.yml, and this repository now uses the same file name for its own. The workflow lists its own path among the files whose change runs every app, so that entry follows the new name: with the old one, a pull request that changes only the workflow would run no app. The README's link to the workflow follows the new name too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FvNuJK2RKgjS5PGMgTuSAF
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the workflow rename and related reference updates.
No open issues 🎉
What changed in this PR
Renames the sample-testing workflow to run-samples.yml to match localstack-azure-samples, making workflow links and CLI commands consistent across both repositories.
Changes:
- Updates the workflow’s shared-file filter so changes to its new path still trigger all 20 sample apps.
- Updates the README link while preserving the workflow’s display name and job names.
| File | Description |
|---|---|
| README.md | Points the workflow link to the renamed file. |
| .github/workflows/run-samples.yml | Renames the workflow and updates its self-referencing change filter. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The workflow that tests the samples of localstack-azure-samples is
run-samples.yml, while the one that tests the samples of this repository issamples.yml.This renames ours, so that both repositories use the same file name for the same pipeline, and links to it and commands that take its file name, such as
gh workflow run run-samples.yml, work the same way in both.Fixes SMF-995
Changes
.github/workflows/samples.ymlbecomes.github/workflows/run-samples.yml, with one line changed..github/workflows/run-samples.yml; with the old one, a pull request that changes only the workflow would run no app.Test samples on LocalStack for Azure, and its job names. GitHub tracks a workflow by its file path, sorun-samples.ymlis a new workflow record, and the runs before this change stay with thesamples.ymlone, under the same name.Tests
.github/workflows/run-samples.ymlandREADME.mdchange, the old step selects no app and the new one selects all 20.shellcheckon that step, and the repository's pre-commit hooks (zizmor,gitleaks).actionlintruns in the "Lint GitHub Actions workflows" check of this pull request.🤖 Generated with Claude Code
https://claude.ai/code/session_01FvNuJK2RKgjS5PGMgTuSAF