Skip to content

Remove migration step 2 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjorkert wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove migration step 2 #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions LoopFollow/Storage/Storage+Migrate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,18 +186,6 @@ extension Storage {
}
}

func migrateStep2() {
// Migrate from old system to new position-based system
if remoteType.value != .none {
remotePosition.value = .position2
alarmsPosition.value = .menu
} else {
alarmsPosition.value = .position2
remotePosition.value = .menu
}
nightscoutPosition.value = .position4
}

// MARK: - Migration helpers (can be removed when step 5 is removed)

/// Check whether a tab item's position was explicitly stored in UserDefaults
Expand Down
11 changes: 5 additions & 6 deletions LoopFollow/ViewControllers/MainViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,12 +639,6 @@ class MainViewController: UIViewController, UNUserNotificationCenterDelegate {
// 2. Update any other StorageValue defaults in Storage.swift that this new step
// mutates, so a fresh install ends up in the same state as a migrated user.

// Step 2: Released in v3.1.0 (2025-07-21). Can be removed after 2026-07-21.
if Storage.shared.migrationStep.value < 2 {
Storage.shared.migrateStep2()
Storage.shared.migrationStep.value = 2
}

// Step 3: Released in v4.5.0 (2026-02-01). Can be removed after 2027-02-01.
if Storage.shared.migrationStep.value < 3 {
Storage.shared.migrateStep3()
Expand All @@ -665,26 +659,31 @@ class MainViewController: UIViewController, UNUserNotificationCenterDelegate {
Storage.shared.migrationStep.value = 5
}

// Step 6: Released in v6.0.0 (2026-04-25). Can be removed after 2027-04-25.
if Storage.shared.migrationStep.value < 6 {
Storage.shared.migrateStep6()
Storage.shared.migrationStep.value = 6
}

// Step 7: Released in v6.0.0 (2026-04-25). Can be removed after 2027-04-25.
if Storage.shared.migrationStep.value < 7 {
Storage.shared.migrateStep7()
Storage.shared.migrationStep.value = 7
}

// Step 8: Released in v6.1.0 (2026-05-05). Can be removed after 2027-05-05.
if Storage.shared.migrationStep.value < 8 {
Storage.shared.migrateStep8()
Storage.shared.migrationStep.value = 8
}

// Step 9: Released in v7.0.0 (2026-07-25). Can be removed after 2027-07-25.
if Storage.shared.migrationStep.value < 9 {
Storage.shared.migrateStep9()
Storage.shared.migrationStep.value = 9
}

// Step 10: Released in v7.0.0 (2026-07-25). Can be removed after 2027-07-25.
if Storage.shared.migrationStep.value < 10 {
Storage.shared.migrateStep10()
Storage.shared.migrationStep.value = 10
Expand Down