Repository navigation
Repaint the search box fully when it is resized - #489
Merged
Merged
Conversation
The search box draws its border along its right edge, but a resize only repainted the newly exposed area, so every old right edge stayed behind as short lines above and below the text box while the window was being resized. Repaint the whole control on resize (double-buffered).
Contributor
Author
|
Now with this fix: 
|
UpdateColumnSize sizes the columns to fit header and content, but that doesn't count the sort arrow ObjectListView draws in the header, nor the priority number when sorting by two columns. With the default sort (Driver Class, then Driver Date) the header read "Drive...". Add their width to the sorted columns.
Contributor
Author
|
"Driver Date" shown as "Drive..." (new since the ObjectListView 3.0.10 update). After 24320c5, the header is drawn by ObjectListView with a sort arrow and, when sorting by two columns, a priority number. UpdateColumnSize sizes columns to fit header and content, but that doesn't count the arrow and number, so with the default sort (Driver Class, then Driver Date) the Driver Date header gets cut. The current release still uses ObjectListView 2.9.1, so it isn't affected. The sorted columns now get that extra width. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While resizing the window, short vertical lines pile up at the right end of the search box, above and below the text. The control draws its border along its right edge, but a resize only repaints the newly exposed area, so each old edge stays on screen.
This turns on ResizeRedraw (with double buffering) so the whole control is repainted on resize. One-line change in EnhancedSearchTextBox's constructor.