Repository navigation
chore: bump net.bytebuddy:byte-buddy from 1.15.11 to 1.18.16 in /android - #461
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.15.11 to 1.18.16. - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.15.11...byte-buddy-1.18.16) --- updated-dependencies: - dependency-name: net.bytebuddy:byte-buddy dependency-version: 1.18.16 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
| // multi-release overlay that this AGP's Jetifier can't parse ("Unsupported | ||
| // class file major version 68"). 1.15.x is the last line without that overlay | ||
| // and is still API-compatible with mockito's usage. | ||
| force 'net.bytebuddy:byte-buddy:1.15.11' | ||
| force 'net.bytebuddy:byte-buddy-agent:1.15.11' | ||
| force 'net.bytebuddy:byte-buddy:1.18.16' | ||
| force 'net.bytebuddy:byte-buddy-agent:1.18.16' |
There was a problem hiding this comment.
🔴 Android unit and instrumentation test builds will likely fail again with "Unsupported class file major version 68", which the 1.15.11 pin was there to prevent. The comment at lines 141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says AGP 8.1.4's Jetifier cannot parse that overlay, and android.enableJetifier=true. 1.18.16 is newer than 1.17.7, so it has that overlay too. Fix: keep the force at 1.15.11, or ignore this bump in dependabot, until the build can run without Jetifier or on an AGP whose Jetifier handles Java 24+ class files. If 1.18.16 is kept, update the comment.
Why this was flagged
android/gradle.properties:26 sets android.enableJetifier=true, and android/build.gradle:8 uses AGP 8.1.4. Mockito 5.24.0 (lines 127-128) brings in byte-buddy and byte-buddy-agent, and configurations.all forces them for every configuration. The comment at lines 141-144 records why they were pinned: byte-buddy 1.17.7 has a META-INF/versions/24 multi-release overlay, and Jetifier fails on it with "Unsupported class file major version 68". 1.15.x is the last line without that overlay. This change forces 1.18.16, which is newer than 1.17.7, so the overlay comes back. That breaks testDebugUnitTest and androidTest dependency transforms, which pass on the base branch with 1.15.11. The comment was not updated, so it now contradicts the pinned version.
Verification: Trigger: any build that resolves a test classpath with Jetifier on. The diff changes android/build.gradle:145-146 from byte-buddy 1.15.11 to 1.18.16. The comment at lines 141-144 says 1.17.7 ships a META-INF/versions/24 overlay that this AGP's Jetifier can't parse. AGP 8.1.4 and Jetifier are still on, with no ignorelist entry for byte-buddy.
Finding ID: f-6e0dc16f
Bumps net.bytebuddy:byte-buddy from 1.15.11 to 1.18.16.
Release notes
Sourced from net.bytebuddy:byte-buddy's releases.
... (truncated)
Changelog
Sourced from net.bytebuddy:byte-buddy's changelog.
... (truncated)
Commits
0229449[publish] Releasing Byte Buddy 1.18.1629c1a29[release] Complete failed release from where it failed.2f7c4edChange tag which was rejected.6ade578[release] Release new version7d6ad78Update checksumsd7bf69fDetect dropped uninitialized 'this' frame in constructors after full frames.2901502Compare constructor frame divergence in frame entries rather than slots.8ade117Update ASM and bridge.4e25942[publish] Start next development iteration 1.18.16-SNAPSHOTf2dffef[publish] Releasing Byte Buddy 1.18.15Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)