Repository navigation
chore: bump net.bytebuddy:byte-buddy-agent from 1.15.11 to 1.18.16 in /android - #462
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [net.bytebuddy:byte-buddy-agent](https://github.com/raphw/byte-buddy) from 1.15.11 to 1.18.16. - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.15.11...byte-buddy-1.18.16) --- updated-dependencies: - dependency-name: net.bytebuddy:byte-buddy-agent dependency-version: 1.18.16 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
| force 'net.bytebuddy:byte-buddy:1.18.16' | ||
| force 'net.bytebuddy:byte-buddy-agent:1.18.16' |
There was a problem hiding this comment.
🔴 Android test builds will likely fail again with "Unsupported class file major version 68" because this bump undoes the pin added to stop that error. The comment at android/build.gradle:141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says this AGP's Jetifier cannot parse that overlay, and that 1.15.x is the last line without it. 1.18.16 is past that line, and android/gradle.properties:26 sets android.enableJetifier=true. Fix: keep both force lines at 1.15.11 and ignore this dependency in dependabot. Or first remove the Jetifier dependency, by disabling it or upgrading AGP 8.1.4, and then update the comment.
Why this was flagged
android/gradle.properties:26 sets android.enableJetifier=true, and the buildscript uses AGP 8.1.4 (android/build.gradle:8). Because of that, Jetifier transforms every resolved artifact in the test classpaths, including byte-buddy that mockito-core/mockito-android 5.24.0 pull in (android/build.gradle:127-128). The new forces at android/build.gradle:145-146 resolve byte-buddy and byte-buddy-agent 1.18.16. That is within the 1.17.x+ range the comment at android/build.gradle:141-144 says ships a META-INF/versions/24 class (major 68) that this Jetifier cannot parse. So testDebugUnitTest and androidTest builds are expected to fail during the Jetifier transform with "Unsupported class file major version 68". On the base branch, the 1.15.11 pin avoids that failure. The PR changes only the version strings and does not change the Jetifier setting or the AGP version, so nothing else guards against the problem. The comment now also contradicts the code.
Verification: The diff changes android/build.gradle:145-146 from force 'net.bytebuddy:byte-buddy:1.15.11' / byte-buddy-agent:1.15.11 to 1.18.16. The conditions that made the pin necessary still hold. android/gradle.properties:26 still has android.enableJetifier=true. The buildscript still uses com.android.tools.build:gradle:8.1.4 (build.gradle:8).
Finding ID: f-34027951
Bumps net.bytebuddy:byte-buddy-agent from 1.15.11 to 1.18.16.
Release notes
Sourced from net.bytebuddy:byte-buddy-agent's releases.
... (truncated)
Changelog
Sourced from net.bytebuddy:byte-buddy-agent's changelog.
... (truncated)
Commits
0229449[publish] Releasing Byte Buddy 1.18.1629c1a29[release] Complete failed release from where it failed.2f7c4edChange tag which was rejected.6ade578[release] Release new version7d6ad78Update checksumsd7bf69fDetect dropped uninitialized 'this' frame in constructors after full frames.2901502Compare constructor frame divergence in frame entries rather than slots.8ade117Update ASM and bridge.4e25942[publish] Start next development iteration 1.18.16-SNAPSHOTf2dffef[publish] Releasing Byte Buddy 1.18.15Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)