Skip to content

serviceability: name both pass counts in the holds_pass_seat comment - #4534

Open
martinsander00 wants to merge 1 commit into
mainfrom
ms/fix-holds-pass-flag-comment
Open

martinsander00 wants to merge 1 commit into
mainfrom
ms/fix-holds-pass-flag-comment

Conversation

@martinsander00

@martinsander00 martinsander00 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary of Changes

  • This PR rewrites the comment on holds_pass_seat in the User account, which said that the flag tracks only the pass-wide multicast count.
  • The flag is also true for an IBRL user, which raised the unicast count on its pass, so the old comment misled a reader about IBRL users.
  • The new comment says that the flag is true for a multicast user only while the user is on a public group or a feed, and that DeleteUser lowers the count only when the flag is true.

@martinsander00
martinsander00 requested review from a team and a balanced review from Copilot November 13, 2026 21:54
@martinsander00
martinsander00 enabled auto-merge (squash) November 13, 2026 21:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The comment inaccurately limits pass-seat retention to public membership, omitting that a user can retain its seat when remaining private group accounts are not supplied.

1 open issue
What changed in this PR

This PR updates the serviceability User account comment to describe both pass counts associated with holds_pass_seat.

Changes:

  • The comment now names both the unicast count and the public multicast count.
  • The comment describes IBRL and multicast users and retains the explanation of count reduction by DeleteUser.
  • The PR changes documentation only, with no runtime or account layout changes.
File Description
smartcontract/​programs/​doublezero-serviceability/​src/​state/​user.rs Revises the comment for holds_pass_seat to describe both pass counts.

Review effort: Balanced

// when this is true. A user that joins only a private group does not raise the count.
// True when this user raised the unicast count or the public multicast count on its pass.
// It is always true for a user that is not multicast, such as an IBRL user.
// For a multicast user, it is true only while the user is on a public group or a feed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants