Repository navigation
serviceability: name both pass counts in the holds_pass_seat comment - #4534
Open
martinsander00 wants to merge 1 commit into
Open
martinsander00 wants to merge 1 commit into
martinsander00 wants to merge 1 commit into
Conversation
martinsander00
requested review from
a team
and
a balanced review from Copilot
November 13, 2026 21:54
martinsander00
enabled auto-merge (squash)
November 13, 2026 21:54
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The comment inaccurately limits pass-seat retention to public membership, omitting that a user can retain its seat when remaining private group accounts are not supplied.
1 open issue
What changed in this PR
This PR updates the serviceability User account comment to describe both pass counts associated with holds_pass_seat.
Changes:
- The comment now names both the unicast count and the public multicast count.
- The comment describes IBRL and multicast users and retains the explanation of count reduction by
DeleteUser. - The PR changes documentation only, with no runtime or account layout changes.
| File | Description |
|---|---|
smartcontract/programs/doublezero-serviceability/src/state/user.rs |
Revises the comment for holds_pass_seat to describe both pass counts. |
Review effort: Balanced
| // when this is true. A user that joins only a private group does not raise the count. | ||
| // True when this user raised the unicast count or the public multicast count on its pass. | ||
| // It is always true for a user that is not multicast, such as an IBRL user. | ||
| // For a multicast user, it is true only while the user is on a public group or a feed. |
bgm-malbeclabs
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
holds_pass_seatin the User account, which said that the flag tracks only the pass-wide multicast count.DeleteUserlowers the count only when the flag is true.