Repository navigation
Prepare the 1.0.0 release - #105
Conversation
mattpodwysocki
left a comment
There was a problem hiding this comment.
Thanks @zmofei. The bump itself looks right to me: Cargo.toml and Cargo.lock agree, the semver wording is consistent across CHANGELOG, CONTRIBUTING and AGENTS.md, and the beta carve-out matches how workflow behaves. I simulated merging #67, #103 and #104 and then this onto main, and it's all clean, no conflicts, cargo build --locked is happy and mapbox --version prints 1.0.0.
The body says this stays a draft until the other three merge, but it's currently marked ready, so nothing stops it going in early. Could you flip it back to draft? Worth knowing too: nothing in the release checks looks for a ## 1.0.0 - <date> heading, so a v1.0.0 tag would go through with every entry still under Unreleased if that last commit got missed.
A couple of things for that last commit:
- The native Arm64 Windows entry still says the Apple Silicon VM case is "the larger of the two populations this serves". Nothing backs that up, so I'd drop the clause. Since this is the first release with that build, it might be worth calling out near the top of the 1.0.0 section.
- After #103 lands, its entry is missing a blank line before the
mapbox usagebullet. - Optional: the sample output in docs/commands.md still shows
mapbox 0.3.0.
|
Thanks @mattpodwysocki. Changed plans: 1.0.0 now covers only what's on main, and #67, #103 and #104 land after it. So this is ready rather than draft, and c7b09f1 adds the
|
mattpodwysocki
left a comment
There was a problem hiding this comment.
Thanks @zmofei for adding the changelog test, that closes the gap nicely. With the new order there are a couple of things I'd like to sort out before we tag:
- Since #104 now lands after 1.0.0, this would be the first release that sends telemetry events at all (0.3.0 only had the User-Agent), and it sends them with the user's own token when they have one, a
tk.login or ansk.in the env. The docs describe that accurately, but it's the exact exposure #104 removes, and tokens stored with events can't be pulled back later. Could we land #104 before tagging? It's approved and green. - I tried merging #103 and #104 on top of this branch. Both merge cleanly, but their changelog entries end up inside the 1.0.0 section, and #104 rewrites two existing 1.0.0 entries in place, so the 1.0.0 notes would say telemetry never used your token. The new test doesn't catch it since the heading is still there. If #104 goes first that part goes away; otherwise both need a rebase that puts their entries under Unreleased.
- CONTRIBUTING.md still uses
mapbox workflowas the beta example, but it won't be in 1.0.0 and nothing on main marks a command beta yet. Could we keep the general rule and drop the example until #67 lands? - Small ones: a line for #106's rustls-webpki/webpki-roots advisory fix would match how 0.2.0 noted its rustls fix, and the heading date will need to match the day it's actually tagged.
c7b09f1 to
5efcc36
Compare
|
@mattpodwysocki Agreed on all four, thanks. #104 now lands before the tag, so its entries go into 1.0.0 as written and the in-place rewrite stops being a problem. #103 still lands after, with its entry under Unreleased. In 5efcc36: dropped the |
mattpodwysocki
left a comment
There was a problem hiding this comment.
Thanks @zmofei, looks good. The advisory entry matches RUSTSEC-2026-0381/0382, and the CONTRIBUTING change reads well. I simulated your order (#104, #103, #108, then this) on main: everything merges cleanly, Unreleased ends up empty, 1.0.0 picks up commands search and the CLI-token-only telemetry wording, and the combined tree builds, prints mapbox 1.0.0 and passes the full suite and clippy. If the tag slips past the 22nd, just bump the heading date.
Bumps the version to 1.0.0, states the 1.0 compatibility rules, and moves the Unreleased entries under a
## 1.0.0 - 2026-10-21heading. 1.0.0 covers what is on main plus #104, which lands first so the first release that sends telemetry events never sends them with a user's token. #67 and #103 land after it, with their entries under Unreleased.Cargo.tomlandCargo.lock: 1.0.0.tests/changelog.rsfails while the version inCargo.tomlhas no## <version> - <date>CHANGELOG heading. Nothing in the release pipeline checks this, so a tag could otherwise ship with every entry still under Unreleased.Tagging and publishing happen in the release pipeline, not here. If this merges on a later day, the heading's date needs updating.
Testing: fmt, clippy and the full suite pass locally on macOS, and
mapbox --versionprints 1.0.0. The new test failed before the heading was added and passes with it. Rebased on main after #106. I also merged #104 and then this branch onto main locally: no conflicts, clippy clean, 919 tests pass, and #104's changelog entries land inside 1.0.0 as intended. The README pins point at a v1.0.0 that won't exist until the release is published.No downstream or operational impact until the release is cut.