Repository navigation
Conversation
A search-eval job runs the eval sets on the PR and its base and writes the scores, and the queries the change fixed and broke, to the job summary. It never fails: the eval_set tests are the gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
commands search evalCI job that runs thecommands searchquery sets on the PR and its base, and writes the scores, plus the queries the change fixed and broke, to the job summary. It never fails; theeval_set_*tests are the gate. Split out of #103 per review.MAPBOX_SEARCH_EVAL_REPORTmakes theeval_set_*tests write each query's result to a directory, even when they fail.scripts/commands-search-report.pyturns the head and base reports into the summary. The Required column shows the scores below which the tests fail (recorded score less the slack).scripts/test-commands-search-report.shchecks the summary against hand-written reports, run in the shell job.No PR comment: the summary needs no write token, so fork PRs get it too.
Testing:
actionlint,shellcheck, the report test and the full suite pass locally, and I ran the eval with reports and rendered the summary. Not verified: the job on GitHub, including the base comparison.Stacked on #103; retarget to
mainonce it merges.