Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #867
Also closes #776, the spike that decided it.
Change
rrand-E runtimearegimu, so the flaguis on:.and[^…]take a whole emoji,[🦖🦕]and🦖+work, and\u{1F996}and\p{L}work without a flag.--void-unicode(-U) turns it off, like the other--void-…flags, for the old reading as UTF-16 parts.-ustays, so old scripts do not fail. With-E regex+it keeps its meaning:uin place ofv.--flagsstill sets all the flags, so--flags gimis the old default. It can not go with-Ueither.u, the error says so:For the release note of v8: patterns with an escape that has no meaning, like
\",\-or\#, a{,}or]on its own, likea{orfoo], or an octal escape like\01now stop the run.-Uis the way back, and the error says it.Tests
The tests that checked the old default now say
voidUnicode: true, like the compatibility table of #854, which comparesrrwith the native engine with the same flags.--unicode"is not the default" is now "is the default, and --void-unicode turns it off", and a test checks the hint, and that a pattern that fails also withoutugets no hint. The flags in the status report aregimu. The flag combinations ofcrossover.test.jsusevoidUnicode.yarn test-cipasses.