Repository navigation
MAINT: declare PromptInject templates as required data - #3546
Draft
Utkarsh Bahuguna (u7k4rs6) wants to merge 16 commits into
Draft
Utkarsh Bahuguna (u7k4rs6) wants to merge 16 commits into
Utkarsh Bahuguna (u7k4rs6) wants to merge 16 commits into
Conversation
This was referenced Oct 26, 2026
…d-data # Conflicts: # tests/unit/scenario/garak/test_api_key.py
…s to selected techniques A required-data refresh committed before the scenario assembled its population, so a refresh that the assembly or the population validators would reject had already replaced the stored datasets, breaking resume of earlier runs. The refresh now runs the scenario's full unsampled assembly against the candidates first, so a rejected refresh changes nothing. Legacy dataset_config validators wrote against the raw template seeds, so they move onto the required data when an old configuration migrates, instead of receiving the assembled objectives. ApiKey now requires a prompt template only for the techniques a run selects.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…work A validator can be any callable, including an unhashable instance such as a plain dataclass, so the migration can't collect them in a set. Remove the moved validators by object identity instead.
…into feat/required-data-prompt-inject
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second scenario for #3336, on top of #3464 so only the last commit is new here. PromptInject's context and technique templates move to get_required_data, and PromptInjectDatasetConfiguration keeps just goal_texts and max_total with the per-goal coverage sampling. Its own uncapped and exact-datasets checks are gone, filters and fetch overrides still reach the templates, and the identity still lists both datasets so old runs resume. Passing the templates as sources still works with a deprecation warning.
Part of #3336