Repository navigation
Support embedding-3 sizing and index migration - #3242
Conversation
Request configured dimensions for named embedding-3 models while preserving Ada behavior. Add an offline migration tool that rebuilds and verifies index copies without modifying originals or rerunning knowledge extraction.
Mock the understanding stylesheet so Jest can load the memory hub suite, and return the feature capabilities expected by the complete-shell fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Fixed the CI blocker in commit c93249d: the browser memory hub suite imported the Understanding stylesheet without a Jest mock, so all six Ubuntu/Windows jobs failed before running it. Once the suite loaded, its complete-shell fixture also needed the current memoryViewCapabilities feature response. Both fixes are test-only; production embedding behavior is unchanged. Local validation on Node 24.22.1:
Monitoring the new CI runs and review feedback. |
Drain preceding editorial maintenance before ingesting the next fixture revision. This prevents a Node 22 CI race where detached retrieval was invalidated mid-read while retaining strict drain assertions and the intentional routing/forget concurrency check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up CI monitoring caught one additional failure: Ubuntu / Node 22's existing editorial-temporal fixture could ingest the next source revision while prior automatic maintenance was still reading its indexed evidence. All other checks on the first fix passed, including the other eight TypeScript matrix jobs and both smoke-test platforms. Fixed in commit 0f7ad2c by draining prior maintenance before each fixture ingest. This keeps the strict failure assertions and the explicit routing/forget concurrency scenario, without production changes, ignored errors, or arbitrary sleeps. A retry-only approach was insufficient in local reproduction, so the fixture now establishes the required ordering directly. Validation: full workspace build and formatting/ratchets passed; the complete editorial-temporal scenario passed three consecutive uncached runs on Node 24.22.1 and three on Node 22.23.4. The full browser test pipeline and root script/memory-quality suites also passed locally. Monitoring the new head's CI and review feedback. |
Capture the child process at launch so cleanup does not resolve a disposed Playwright application channel. Avoid killing already-exited processes. Add an offline regression test to the shell test pipeline that proves startup retries continue after an early application exit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Additional test-harness reliability fix in 493f6eb: retain Electron child-process handles at launch instead of looking them up through an application channel that may already be disposed during failed-startup cleanup. Already-exited processes are not killed. The existing bounded launch retries can now proceed as intended. Added an offline startup regression to the shell unit-test pipeline. It reproduces the cleanup failure before the fix and passes afterward, without launching Electron or loading credentials. Strict TypeScript validation, shell unit tests, full workspace build, formatting, policy checks and ratchets passed. The complete local memory-service suite also passed: 94 suites / 1,333 tests. Monitoring CI on this new head; no review comments have appeared so far. |
|
Final verification for head 493f6eb: all CI checks are green — 29 passed, 1 intentionally skipped, none pending or failed. All nine TypeScript OS/Node matrix jobs passed, as did shell packaging, .NET, CodeQL, policy/formatting/regeneration and Linux/Windows smoke checks. Pushed commits:
Local validation included the full workspace build, complete browser package pipeline, 480 aiclient tests, all 1,333 memory-service tests (94 suites), shell unit tests and strict startup-regression type checking, root scripts/memory-quality tests, and CI quality gates. The editorial regression also passed three uncached runs each on Node 22.23.4 and 24.22.1. No review comments or unresolved threads were present at the final refresh. The worktree is clean and the PR reports mergeable; no merge was performed. |
Request configured dimensions for named embedding-3 models while preserving Ada behavior. Add an offline migration tool that rebuilds and verifies index copies without modifying originals or rerunning knowledge extraction.