Repository navigation
Bump mdn BCD to 8.0.5 - #2557
Conversation
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
| * | ||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStream/from_static) | ||
| */ | ||
| from(asyncIterable: never): ReadableStream; |
There was a problem hiding this comment.
Now we need to deal with this
There was a problem hiding this comment.
I just made it never what it should be?
There was a problem hiding this comment.
Something not never, likely AsyncIterable | Iterable per https://webidl.spec.whatwg.org/#js-async-iterable. And skip AsyncIterable where it's not available.
There was a problem hiding this comment.
Updated
|
Please tell the version in the PR title |
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
| JSON.stringify(obj), | ||
| ); | ||
| return "never"; // Use 'never' to signal omission in type generation | ||
| if (compilerBehavior.treatAsyncSequence) { |
There was a problem hiding this comment.
It's not letting asynciterable.d.ts emit the extra signature, it should.
There was a problem hiding this comment.
How do we emit to asynciterable.d.ts, I tried to understand how it emits but couldn't solve it.. feel free to cherry pick the pr if you want
There was a problem hiding this comment.
How do I emit it Kagami Sascha Rosylight (@saschanaz)
There was a problem hiding this comment.
Refer to existing logic to have Iterable signatures conditionally, we should be able to do the same.
There was a problem hiding this comment.
And Iterable itself should be there so ES5 won't get it.
I'm not sure how much we want to spend time to support older TS compilers though? There's no policy, and I never really intend to maintain all the matrix, it was only added to cover the massive ArrayBuffer change and since then it only added up.
Thoughts? Jake Bailey (@jakebailey)
There was a problem hiding this comment.
I'm not sure how old you're planning on dropping, but we could probably drop anything older than 5.8, or at least match DT
There was a problem hiding this comment.
Good, let's drop them, in a separate PR
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
|
I have updated it Kagami Sascha Rosylight (@saschanaz) |
|
What do you think for this pr what is left to get this going? Kagami Sascha Rosylight (@saschanaz) |
|
Type additions are good, will accept once the test finishes |
|
LGTM |
|
Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks! |
No description provided.