Make options required in MutationObserver.observe()

baselines/dom.generated.d.ts

@@ -25734,7 +25734,7 @@ interface MutationObserver {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/MutationObserver/observe)
      */
-    observe(target: Node, options?: MutationObserverInit): void;
+    observe(target: Node, options: MutationObserverInit): void;
     /**
      * The MutationObserver method **`takeRecords()`** returns a list of all matching DOM changes that have been detected but not yet processed by the observer's callback function, leaving the mutation queue empty.
      *

baselines/ts5.5/dom.generated.d.ts

@@ -25710,7 +25710,7 @@ interface MutationObserver {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/MutationObserver/observe)
      */
-    observe(target: Node, options?: MutationObserverInit): void;
+    observe(target: Node, options: MutationObserverInit): void;
     /**
      * The MutationObserver method **`takeRecords()`** returns a list of all matching DOM changes that have been detected but not yet processed by the observer's callback function, leaving the mutation queue empty.
      *

baselines/ts5.6/dom.generated.d.ts

@@ -25731,7 +25731,7 @@ interface MutationObserver {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/MutationObserver/observe)
      */
-    observe(target: Node, options?: MutationObserverInit): void;
+    observe(target: Node, options: MutationObserverInit): void;
     /**
      * The MutationObserver method **`takeRecords()`** returns a list of all matching DOM changes that have been detected but not yet processed by the observer's callback function, leaving the mutation queue empty.
      *

baselines/ts5.9/dom.generated.d.ts

@@ -25731,7 +25731,7 @@ interface MutationObserver {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/MutationObserver/observe)
      */
-    observe(target: Node, options?: MutationObserverInit): void;
+    observe(target: Node, options: MutationObserverInit): void;
     /**
      * The MutationObserver method **`takeRecords()`** returns a list of all matching DOM changes that have been detected but not yet processed by the observer's callback function, leaving the mutation queue empty.
      *

inputfiles/patches/dom.kdl

@@ -26,6 +26,15 @@ interface Document {
   }
 }
 
+// observe() always throws a TypeError when none of childList, attributes or characterData ends up true,
+// so calling it without options can never work. Web IDL can't express that dependency, hence the default {}.
+// See https://dom.spec.whatwg.org/#dom-mutationobserver-observe
+interface MutationObserver {
+  method observe signatureIndex=0 {
+    param options optional=#false
+  }
+}
+
 interface MutationRecord {
   property type type=MutationRecordType
 }

src/build/patches.ts

@@ -361,6 +361,7 @@ function handleParam(node: Node) {
     name,
     ...handleTyped(typeNodes, node.properties?.type),
     ...optionalMember("overrideType", "string", node.properties?.overrideType),
+    ...optionalMember("optional", "boolean", node.properties?.optional),
     ...(additionalTypes ? { additionalTypes } : {}),
   };
 }

unittests/files/mutationobserver.ts

@@ -0,0 +1,10 @@
+const observer = new MutationObserver(() => {});
+
+// @ts-expect-error options are required, observe() throws without them
+observer.observe(document.body);
+
+observer.observe(document.body, { childList: true });
+observer.observe(document.body, { attributeFilter: ["class"] });
+
+declare const options: MutationObserverInit;
+observer.observe(document.body, options);