Repository navigation
Export WINRT_IMPL_* in winrt_base.ixx so Windows.Foundation can access them - #1644
Open
Yexuan Xiao (YexuanXiao) wants to merge 2 commits into
Open
Yexuan Xiao (YexuanXiao) wants to merge 2 commits into
Yexuan Xiao (YexuanXiao) wants to merge 2 commits into
Conversation
Contributor
Author
|
Ryan Shepherd (@DefaultRyan) Could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1643.
winrt.Windows.Foundation.ixx needs
WINRT_IMPL_CreateEventW, butWINRT_IMPL_CreateEventWis declared in winrt_base.ixx without being exported. Because MSVC can erroneously access declarations in the global module that should be invisible, this problem was not discovered during the earlier implementation.The following fix options are also possible:
winrt::implnamespace to these C functions (extern "C" will ensure their linkage).Since CMake and MSBuild do not yet support building the std module with Clang and STL (this will probably be done next year), no test was added, but this patch is very simple.