Repository navigation
Fix winrt_numerics treating the standard library as part of its own implementation - #1648
Open
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Open
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1647.
winrt_numerics.ixx includes
windowsnumerics.impl.hin the module purview as its implementation, butwindowsnumerics.impl.htransitively includes other standard library headers, causing some standard library definitions to also become part of thewinrt_numericsimplementation. The global module fragment includesdirectxmath.h,directxmath.halso transitively includes standard library headers, and unlikewindowsnumerics.impl.h. This causes winrt_numerics.ixx to be expanded into the following pseudocode:Once
stdheader1declares a classAbutAis defined instdheader2, this violates the standard's requirements, causing the build to fail. Since MSVC is known to be non-conforming on this issue and uses a relaxed strategy, this problem was not discovered in the previous implementation.Link to windowsnumerics.impl.h of mingw-w64.