Repository navigation
Avoid using intrinsics in Windows.Foundation.ixx - #1649
Open
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Open
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Yexuan Xiao (YexuanXiao) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1646.
Windows.Foundation.hcurrently uses_InterlockedCompareExchangePointerbut does not include the required header, which causes GCC and GNU mode Clang builds to fail. MSVC mode Clang treats_InterlockedCompareExchangePointeras a built-in intrinsic and does not need to include intrin.h, while MSVC, due to the bug, incorrectly accessed a declaration that should have been invisible.Rather than modifying the generator to include
intrin.h, it would be better to use C++20'sstd::atomic_refto avoid this issue.