Repository navigation
fix(http-client-csharp): preserve constructors with approved framework defaults - #12311
Closed
Wei Hu (live1206) wants to merge 1 commit into
Closed
Wei Hu (live1206) wants to merge 1 commit into
Wei Hu (live1206) wants to merge 1 commit into
Conversation
commit: |
Contributor
|
No changes needing a change description found. |
Contributor
Author
|
Withdrawing this framework-defaulting proposal in favor of the revised plan: keep the known SDK legacy constructor and use existing The updated cleanup handoff is Azure/azure-sdk-for-net#63992 (comment). - by copilot |
Wei Hu (live1206)
deleted the
fix/12304-network-constructor-preservation
branch
October 20, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12304 (the Network constructor follow-up), split out of #12310.
Independence and scope
Design status: constructor/defaulting policy is still under discussion. This draft isolates the existing proposal for review; it is not a finalized decision about how current handwritten constructors should control generation.
This PR targets main independently of #12310 and does not include its mapped-hierarchy/property-projection changes. The constructor fixture supplies an already-restored flat hierarchy; actual flat-base discovery remains #12303.
The downstream management generator must opt into the known historical default alongside Azure/azure-sdk-for-net#63998 before the real Network cleanup uses this path. No real Network GA ApiCompat run, SDK regeneration, or inherited ARM-envelope JSON-roundtrip validation is claimed.
Change-specific validation
- by copilot