Repository navigation
PR shows green checkmark for ready to commit even though branch protection policy is not met yet (review pending) #8813
Description
Type: Bug
Branch protection policy states at least one review is required. There is a review requested which has not been made yet. The PR shows the green checkmark instead of the orange circle I would expect for that situation. I have two of them which exhibit this behavior:
bugzilla/harmony#147
bugzilla/harmony#155
Both status "Merging is blocked: At least 1 approving review is required by reviewers with write access." at the bottom.
Extension version: 0.152.0
VS Code version: Code 1.126.0 (Universal) (7e7950df89d055b5a378379db9ee14290772148a, 2026-06-23T01:46:13Z)
OS version: Darwin x64 25.5.0
Modes:
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400) |
| GPU Status | 2d_canvas: enabled GPU0: VENDOR= 0x1002, DEVICE=0x7340, DRIVER_VENDOR=Intel, DRIVER_VERSION=26.5.1 GPU1: VENDOR= 0x8086, DEVICE=0x3e9b ACTIVE Machine model name: MacBookPro Machine model version: 16.1 direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: enabled_on trees_in_viz: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgpu: enabled webnn: disabled_off |
| Load (avg) | 3, 3, 3 |
| Memory (System) | 64.00GB (0.92GB free) |
| Process Argv | --crash-reporter-id 1a914a65-8a1b-4df3-8246-797620b9e1cb |
| Screen Reader | yes |
| VM | 0% |
A/B Experiments
vsliv368:30146709
binariesv615:30325510
nativeloc1:31344060
dwcopilot:31170013
dwoutputs:31242946
copilot_t_ci:31333650
e5gg6876:31282496
pythonrdcb7:31342333
6518g693:31463988
aj953862:31281341
6abeh943:31336334
envsdeactivate2:31538737
478i5457:31521843
cloudbuttont:31379625
3efgi100_wstrepl:31403338
ec5jj548:31422691
cp_cls_t_966_ss:31526232
8hhj4413:31478653
38bie571_auto:31426784
cp_cls_t_1081:31454832
conptydll_true:31498968
ia-use-proxy-models-svc:31452481
e9c30283:31461165
test_treatment2:31471001
46204921:31447328
idci7584:31464702
e3e4d672:31494082
ei9d7968:31496641
nes-extended-on:31455476
chat:31457767
8hig5102:31480529
89g7j272:31518289
7e187181:31503455
i2gc6536:31499202
52612955:31516516
ghj88844:31499326
ddid_c:31478207
hmra_i5g22:31518061
7df3h592:31512476
cp_cls_t_1082:31535311
logging_enabled_new:31498466
db5d2638:31499441
jb_cp_cls_t_632:31537244
b1ei0813:31506238
56dj4588:31512888
32d76977:31512328
ha629193:31508444
cdk-lw-on:31524445
2cfga817_c:31522397
jh5f2457_c:31540921
api_cot_off:31513532
41836166:31537719
jbcp_cls_pctr_t:31531130
61138546:31518536
cp_intellij_c_nes:31533503
jf4hg949:31526829
nes-curr-leftover-1500:31538366
h561g132:31533256
session_8:31532895
h7dd7680:31541765
hjji5903:31534458
7g2b5551:31542111
Activity
alexr00 commentedon Jun 30, 2026
Are you seeing this on GitHub.com, or in the VS Code "GitHub Pull Request" extension?
justdave commentedon Jul 1, 2026
in the VS Code "GitHub Pull Request" extension. It looks correct on GitHub, and the indicators in the extension don't match GitHub in these two cases.
alexr00 commentedon Jul 1, 2026
Got it. Can you share a screenshot of what you're seeing?
justdave commentedon Jul 2, 2026
In the "Created by me" section, the four "[Harmony]" ones are all still blocked on reviews, but have the green checkmark on the right.. The "[5.2]" and "[5.0.4]" ones that have the orange circle are also blocked on reviews (and the orange circle matches GitHub's indicator on the website for "reviews pending"). The "[5.3]" ones are actually ready to land, so the green checkmark is accurate on those.
If it matters any, I have related code base in different forks that live in different remotes (GitHub CoPilot can compare them all with each other using git commands that way), so I have three repos configured to look at pull requests. The ones that are correct are all in the same repo with each other, and the ones that are not correct are all in a different repo but same one as each other. In case it's related to something assuming all pull requests would be in the same repo.
alexr00 commentedon Jul 3, 2026
I can see that if we aren't able to get the status checks that we're not handling that correctly. Given that the incorrect ones are all from the same repo, I think that's what's happening here. Instead of displaying the "all good" icon for these, we should show no icon. Can you share the output of "GitHub Pull Request" next time you see this?
alexr00 commentedon Jul 3, 2026
I'm making a fix for incorrectly showing the "double check" when we should show nothing. Once I have logs I can see what I can do about why we aren't able to get the checks for those PRs.
Handle unknown checks case (#8827)
justdave commentedon Jul 4, 2026
I'm not sure what you're asking for here. From the other context it sounds like you want a log. Where do I find that log?
There is a cofiguration dialog which lets you set multiple remotes for which to grab PRs from. The behavior is consistant with it using all of those remotes to fetch the list of PRs but only one of them to fetch the statuses. And I'm not sure how it's deciding which one to use for the statuses because it's not the first one in the list that has the accurate ones (it's the second one).
Also, it looks like mentioning this in a commit made it close the issue report, so I dunno if you'll see this.
justdave commentedon Jul 4, 2026
I guess since it's closed I should actually Alex Ross (@alexr00) you. :-)
One other observation - it doesn't seem to follow the remote belonging to the branch I currently have checked out, either. If I switch to a branch on a different remote and refresh the pull requests, the statuses don't change.
alexr00 commentedon Jul 7, 2026
Can you share a screenshot?
Open the Output panel, and choose "GitHub Pull Request" from the dropdown.
justdave commentedon Jul 7, 2026
GitHub Pull Request output log
alexr00 commentedon Jul 9, 2026
Thanks for the info! I think I see what's up. The latest stable version (0.156.0) should be showing no green checks for these PRs. Starting tomorrow, the pre-release version (requires latest VS Code Insiders) should show
pendingfor these PRs.Try fix "awaiting approval" issue (#8835)