Skip to content

Shared segmented control for both themes - #8231

Merged
renemadsen merged 1 commit into
stablefrom
feat/segmented-shared
Nov 20, 2026
Merged

renemadsen merged 1 commit into
stablefrom
feat/segmented-shared

Conversation

@renemadsen

Copy link
Copy Markdown
Member

Moves the eForm Classic drawing of .segmented / .segmented-option and the :focus-visible ring out of the backend-configuration plugin's compliance report SCSS into a shared partial (scss/components/_segmented.scss), and adds a :disabled state for both themes: default cursor, text at 38 % of --md-on-surface, and a neutral fill on the checked option.

The plugin's tail-bite risk assessment will use this control for its Ja|Nej answers (microting/eform-backendconfiguration-plugin#1517). The plugin PR then deletes its local copy. This PR has to merge and deploy first, otherwise the compliance toggle loses its Classic styling.

Verified: the partial compiles with sass, and the disabled rules come after workspace §5 in the output. Not verified in a browser.

🤖 Generated with Claude Code

Moves the eForm Classic drawing of .segmented/.segmented-option and the
focus ring out of the compliance report's component SCSS into shared
SCSS, and adds a disabled state for both themes (default cursor, text at
38 %). Needed by the tail-bite risk assessment's Ja|Nej toggle
(microting/eform-backendconfiguration-plugin#1517).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 09:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The unavailable dependent plugin PR prevented styling-parity checks, leaving browser behavior in both themes and frontend-first deployment sequencing for human verification before plugin-local styles are removed.

No open issues 🎉

What changed in this PR

Centralizes segmented-control styling in the shared frontend styles so plugin controls can reuse it across both themes. This must deploy before the backend-configuration plugin removes its local Classic styles.

Changes:

  • Adds Classic styling, a shared focus-visible ring, and disabled states for both themes.
  • Loads the shared partial after workspace utilities to preserve the intended cascade.
File Description
eform-client/​src/​scss/​components/​_segmented.scss Adds shared Classic, focus, and disabled styling for segmented controls.
eform-client/​src/​scss/​components/​_index.scss Imports the segmented partial after workspace utilities.

Review effort: Balanced

@renemadsen
renemadsen merged commit 93546bb into stable Nov 20, 2026
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants