Repository navigation
Shared segmented control for both themes - #8231
Merged
Merged
Conversation
Moves the eForm Classic drawing of .segmented/.segmented-option and the focus ring out of the compliance report's component SCSS into shared SCSS, and adds a disabled state for both themes (default cursor, text at 38 %). Needed by the tail-bite risk assessment's Ja|Nej toggle (microting/eform-backendconfiguration-plugin#1517). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The unavailable dependent plugin PR prevented styling-parity checks, leaving browser behavior in both themes and frontend-first deployment sequencing for human verification before plugin-local styles are removed.
No open issues 🎉
What changed in this PR
Centralizes segmented-control styling in the shared frontend styles so plugin controls can reuse it across both themes. This must deploy before the backend-configuration plugin removes its local Classic styles.
Changes:
- Adds Classic styling, a shared focus-visible ring, and disabled states for both themes.
- Loads the shared partial after workspace utilities to preserve the intended cascade.
| File | Description |
|---|---|
eform-client/src/scss/components/_segmented.scss |
Adds shared Classic, focus, and disabled styling for segmented controls. |
eform-client/src/scss/components/_index.scss |
Imports the segmented partial after workspace utilities. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the eForm Classic drawing of
.segmented/.segmented-optionand the:focus-visiblering out of the backend-configuration plugin's compliance report SCSS into a shared partial (scss/components/_segmented.scss), and adds a:disabledstate for both themes: default cursor, text at 38 % of--md-on-surface, and a neutral fill on the checked option.The plugin's tail-bite risk assessment will use this control for its Ja|Nej answers (microting/eform-backendconfiguration-plugin#1517). The plugin PR then deletes its local copy. This PR has to merge and deploy first, otherwise the compliance toggle loses its Classic styling.
Verified: the partial compiles with sass, and the disabled rules come after workspace §5 in the output. Not verified in a browser.
🤖 Generated with Claude Code