Repository navigation
feat(theme): workspace patterns for the CRM phase 2 screens - #8232
Open
renemadsen wants to merge 2 commits into
Open
renemadsen wants to merge 2 commits into
renemadsen wants to merge 2 commits into
Conversation
Year cards, lifetime block, lock bar, price rows, an SVG bar chart with legend, funnel and stage tiles for Abonnement, Pipe-line and KPI. Adds the .visually-hidden utility the CRM pages already use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Chart bars, legend swatches, and the dark-mode success segment lack sufficient boundary contrast, making their shapes and extent difficult for low-vision users to discern.
2 open issues
What changed in this PR
Adds shared workspace styles for upcoming CRM phase 2 screens. The new patterns are scoped to body.theme-workspace and are not yet used by core app components.
Changes:
- Add subscription cards, lifetime summaries, calculator rows, and lock/price treatments.
- Add responsive charts, funnels, and stage tiles with keyboard-focus and pressed-state cues.
- Define a global
.visually-hiddenutility for screen-reader-only content across themes.
| File | Description |
|---|---|
eform-client/src/scss/components/_workspace-patterns.scss |
Adds CRM phase 2 styling patterns and the global screen-reader-only utility. |
Review effort: Balanced
…l for 3:1 contrast Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Milestone 0 of CRM phase 2 (spec: microting/angular-my-microting-plugin#843, §9.5). Only adds to
_workspace-patterns.scss; nothing in the core app uses these classes yet.New, under
body.theme-workspace:.calc-line,.year-grid/.sub-year,.sub-life,.sub-lock,.sub-price/.sub-price-box,.chart-grid,.bar-chart(+.bar-chart-legend),.funnel,.stage-tiles/.stage-tile.Global:
.visually-hidden(screen-reader-only). The CRM tasks and tickets pages already use the class but nothing defined it.Colours are tokens +
color-mix()only; pressed stage tiles have a non-colour cue; layouts usemin(100%, …)minimums and a 560px funnel breakpoint.Verified: the partial compiles with Dart Sass. Not verified in a browser (light/dark, phone width) — that happens when the phase 2 screens land.
🤖 Generated with Claude Code