Skip to content

feat(theme): workspace patterns for the CRM phase 2 screens - #8232

Open
renemadsen wants to merge 2 commits into
stablefrom
feat/crm-phase2-workspace-styles
Open

renemadsen wants to merge 2 commits into
stablefrom
feat/crm-phase2-workspace-styles

Conversation

@renemadsen

Copy link
Copy Markdown
Member

Milestone 0 of CRM phase 2 (spec: microting/angular-my-microting-plugin#843, §9.5). Only adds to _workspace-patterns.scss; nothing in the core app uses these classes yet.

New, under body.theme-workspace: .calc-line, .year-grid / .sub-year, .sub-life, .sub-lock, .sub-price / .sub-price-box, .chart-grid, .bar-chart (+ .bar-chart-legend), .funnel, .stage-tiles / .stage-tile.

Global: .visually-hidden (screen-reader-only). The CRM tasks and tickets pages already use the class but nothing defined it.

Colours are tokens + color-mix() only; pressed stage tiles have a non-colour cue; layouts use min(100%, …) minimums and a 560px funnel breakpoint.

Verified: the partial compiles with Dart Sass. Not verified in a browser (light/dark, phone width) — that happens when the phase 2 screens land.

🤖 Generated with Claude Code

Year cards, lifetime block, lock bar, price rows, an SVG bar chart with
legend, funnel and stage tiles for Abonnement, Pipe-line and KPI. Adds the
.visually-hidden utility the CRM pages already use.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 17:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Chart bars, legend swatches, and the dark-mode success segment lack sufficient boundary contrast, making their shapes and extent difficult for low-vision users to discern.

2 open issues
What changed in this PR

Adds shared workspace styles for upcoming CRM phase 2 screens. The new patterns are scoped to body.theme-workspace and are not yet used by core app components.

Changes:

  • Add subscription cards, lifetime summaries, calculator rows, and lock/price treatments.
  • Add responsive charts, funnels, and stage tiles with keyboard-focus and pressed-state cues.
  • Define a global .visually-hidden utility for screen-reader-only content across themes.
File Description
eform-client/​src/​scss/​components/​_workspace-patterns.scss Adds CRM phase 2 styling patterns and the global screen-reader-only utility.

Review effort: Balanced

…l for 3:1 contrast

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 17:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the shared CRM workspace styling changes.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants