Repository navigation
version.py: accept semver-style prerelease tags (v0.10.0-rc.1) - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found dry-running the release procedure: release tags are semver-style (v0.10.0-rc.1) because Cargo requires that form for the crate version, but version.py only parsed the PEP 386 form (0.10.0rc1) — a semver tag made get_version() raise, which would have failed the release's sdist step. This normalizes the prerelease segment (-rc.1 to rc1) before parsing; final and historic rc tags parse as before. Verified against synthetic tags in a scratch clone (v0.10.0-rc.1 yields 0.10.0rc1; the original version.py raises on it).