Repository navigation
release.sh: fix the cleanup trap glob for the per-target lib layout - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dry-running the release found this: the cleanup trap removes genomicsqlite/*/libgenomicsqlite.so, a glob from before the per-target layout, so it matches nothing and the staged libraries survive the run. The trap exists so a later release cannot silently ship stale libraries, and the presence check would pass on the leftovers. This adds the missing lib/ level. Note: the connector push reset the file's executable bit; it needs a chmod commit on this branch (commands in chat).