Repository navigation
fix: keep stdio server handling messages after one fails - #1205
Open
prathamgoyal787 wants to merge 1 commit into
Open
prathamgoyal787 wants to merge 1 commit into
prathamgoyal787 wants to merge 1 commit into
Conversation
StdioServerTransportProvider fed every inbound message through one flatMap, so an error from a single message (for example a failing notification handler) terminated the inbound stream. The server process stayed alive but never answered another request, not even ping. Errors are now handled per message, logged, and the stream keeps going.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StdioServerTransportProvidersends every inbound message through a singleflatMap, so an error from one message ends the whole inbound stream.McpServerSession.handlepasses notification-handler errors through withdoOnError. One example: a client sendsnotifications/roots/list_changed, then answers the server'sroots/listwith an error. After that, the stdio server process stays alive but never answers another request, not evenping.This change handles errors per message: they're logged and the stream keeps going.
Added
shouldKeepHandlingMessagesAfterOneFailstoStdioServerTransportProviderTests. It fails onmain(thepingafter the failing notification is never handled) and passes with this change. Allmcp-coretests pass.