Repository navigation
Conversation
Quest-Claim: 0623f95ac6e214cc
…ts in /quest-run - /quest-afk: bare `afk` runs it; `afk merge` merges strongly recommended low or medium PRs with a counting review and no decisions or follow-ups, deferring high or unclassified ones; `afk soon` asks pending questions in one batch, then goes afk. - `Maintainer (PC):` marks a step only the maintainer's computers can take; `quest waiting --no-pc` drops them and --json reports `pc`; `quest check` rejects other maintainer qualifiers. - /quest-run waits on ready PRs whose required checks are still running, and skips or front-loads PC steps by its argument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…normalized party Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…waiting help Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes
quest/m0/afk-and-waits.md, planned in moq-dev/quest#796: fewer repeated prompts in AFK, travel, and back-at-the-desk sessions.Summary
/quest-afkmodes (assets/skills/afk.md). A bareafkmessage now runs the skill. The description namesafk,afk merge, andafk soonso the harness matches them, and the regenerated stubs carry it.afkstays conservative: only standing picks merge.afk mergeruns/quest-mergeonly on a PR that meets all of these: you strongly recommend it,quest statusshows it low or medium for its head, a review counts for that head, it has no open decision and no follow-ups, and it deletes or deprioritizes no quest beyond the one it finishes. High-risk and unclassified PRs are deferred.afk soonasks every pending question in one batch, the way/quest-run's "decisions" does, then switches to afk on its own.afk soon merge. A merge grant that names no risk tier counts asmerge.afk mergeas permission to merge anything and landed high-risk moq-dev/quest#807. This mode would have deferred it.src/core/waiting.ts,quest waiting,quest check, guide Format section, README).## Waitingitem that opens withMaintainer (PC):is a step the maintainer can take only at one of their computers, such as a password-manager unlock, a hardware check, or a local login. It still counts as the maintainer's everywhere: ranking,--maintainer, and the writer-size bump inmodels.ts.quest waiting --no-pcdrops those items before ranking, so a quest left with only an outside party's item ranks like one.--jsonaddspcto each wait, and text output printsMaintainer (PC): ….quest checkrejects any other maintainer qualifier, such asMaintainer (local):, so a typo can't quietly become an outside party. In a draft's hand-back, which isn't checked, such an item falls back to the maintainer with its text intact.quest/m1/cursor-reviewer.md's macOS Cursor login is now aMaintainer (PC):item./quest-run(assets/skills/run.md).remote,on my phone), it reads waits with--no-pc. When it saysat my PC, it asks those items first.quest waiton ready-for-review PRs whose required checks are still running and that a later round would pick or ask about. It runs another round when their checks finish, and doesn't finish while one is still running. Drafts and skipped PRs are still never waited on.Public API
quest waiting: new--no-pcflag.--jsonwait objects gainpc: boolean. Text lines printMaintainer (PC):for those items.quest check: rejects aMaintainer (<other>):qualifier, which it previously accepted as an outside party.waiting(docs, today, drafts)becomeswaiting(docs, today, { drafts, maintainer, pc }), andWaitgainspc. kixel-ai/kixel.quest calls onlywaiting(docs, today)andparseWait, which still compile.parseWaitnow returnsnullfor aMaintainer (<other>):qualifier.!(nothing is in production).Choices made without asking
The maintainer is away. Each choice below is mine and is open to review:
Maintainer (PC):, not(local). It matches the maintainer's own wording ("at my PC") and the"Not at my PC (defer)"option thatquest/m0/dialog-options.mdplans. Only(PC)is accepted, case-insensitive. Anything else failsquest check.--no-pc, instead of the plan's--pcplus--decisions. Away sessions need the exclusion. At-PC sessions want everything, and--json'spclets them put PC items first. A "decisions only" filter can't be told apart from plainMaintainer:actions on a website, so it would mislabel them.waiting(), so ranking follows the items that are kept. Filtering after ranking would leave a quest whose only maintainer item was dropped still sorted among the maintainer's. Options are a struct, to stay under four arguments.afk mergescope: low or medium risk only, never unclassified. PRs with follow-ups are deferred, since their keep/drop questions need the user's pick. Quest deletions beyond the PR's own quest are deferred.afk soon: once the batch prompt returns, unanswered questions are handled like any other afk question, either taken on recommendation or deferred. There is no second prompt.quest wait's existingchecks:passed/checks:failed. See## Waitingfor the reviewers' objection.quest wait's rule thatchecks:passedfires only when every check is idle, and merge as is. Rejected: a required-only wake in this PR, and a follow-up quest for one. Waiting for every check also keeps/quest-mergefrom queueing a PR whose optional check fails moments later. The stall needs a check that never finishes in a session waiting on nothing else, since any other activity runs a round that re-reads every PR.Validation
just test(1566 passed, 5 skipped),just check,quest check, and the affected tests (skills,cli,waiting) pass again.just checkandjust testpass: 55 files, 1566 tests passed, 5 skipped, plus both lifecycle checks.Maintainer (PC):, lowercasemaintainer(pc):, a rejected(local),Maintainers:still read as an outside party, and draft hand-back fallback--no-pcand--maintainerfiltering, including a quest re-ranking once its PC item is droppedquest check's new message--json, and--maintainer --no-pcoutputquest waiting --maintainerlists the Cursor login asMaintainer (PC): …alongside the moq-dev/quest#805 draft. With--no-pc, only quest review runs reviewers through the Cursor CLI #805 remains.--json, only that item haspc: true; outside parties keeppc: false.Maintainer (local):,quest checkfails atquest/m1/cursor-reviewer.md:64with the new message.test/skills.test.tskeeps it underINLINE_LIMIT, andquest checkpasses with the regenerated stubs.Follow-ups
None.
quest/m0/dialog-options.md(running concurrently) owns the"Not at my PC (defer)"dialog option that complements these waits.Models
Size: M
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm B)
Implementer: Claude Code, claude-opus-5-5, unknown effort (iterate, XS, arm B)
(Written by Opus 5.5)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 3c255ac, named in full once no reviewer reports a finding
Base: origin/main at a88c65b
Risk: high,
The `afk merge` mode in assets/skills/afk.md (and the matching README text) newly lets an agent merge low- and medium-risk PRs without asking, which a user, or the maintainer's repositories, could be hurt by if the agent misjudges a PR, and a revert can stop future merges but not merges already made; the risk file lists a change to when an agent may merge without asking in assets/ as high. The `quest waiting` output and `--json` shape also change for consumers that parse them, which is medium on its own.Classified: high by Claude Code, claude-haiku-5-5, low effort, session
2fb884d2-553b-4807-a8e4-91b0c7c08e5eReviewer: Codex, gpt-6.1-sol, high effort
Session:
01a20232-23a5-7d21-9e6a-3681fabd97b7, round 2Score: 10/10,
The incremental README and CLI help changes accurately describe the existing behavior; static review found no defects, and no builds or tests were run as instructed.Rounds: 5; first round 1 (medium 1); findings 1 (medium 1): fixed 0, refuted 1, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, xhigh effort, shadow
Session:
01a20232-23a4-75e1-9acf-a45945d8dc46, round 2Score: 7/10,
The README and help updates are consistent, but an optional check can still stall the pending-CI loop.Rounds: 5; first round 1 (medium 1); findings 1 (medium 1): fixed 0, refuted 0, open 1
Findings, open until the next round settles them:
assets/skills/run.md:80:Wake pending-CI rounds when required checks finishThe last round's findings, at 5ca8193:
assets/skills/run.md:80:Wake pending-CI rounds when required checks finish;The response explicitly leaves the behavior unchanged, and src/github/wait.ts:597-600 plus test/wait.test.ts:770-804 confirm that required checks finishing cannot wake the loop while an optional check remains pending.Reviewer: Claude Code, claude-sonnet-5-5, medium effort, second
Session:
ba96cd9c-06e9-4c5d-9ad0-b8905f6cd8ea, round 2Score: 8/10,
The README and help text are fixed and the remaining responses hold, but afk merge still lets an agent merge without asking, so it lands after the maintainer confirms that choice.Rounds: 5; first round 5 (high 1, medium 1, low 3); findings 10 (high 1, medium 4, low 5): fixed 4, refuted 6, open 0
Findings: none
The last round's findings, at 5ca8193:
README.md:2473:Skills table still describes quest-afk by its old contract;The README skills table row for quest-afk now names `afk merge` and `afk soon`.assets/skills/afk.md:13:Mode text leaves argument forms undefined and narrows a bare merge grant;The author cites the quest Goal as the recorded decision, which says to merge non-high-risk PRs and defer high-risk ones. Reading an untiered grant as `merge` is therefore the intended behavior, and afk.md:16 lets a user widen it.src/core/waiting.ts:41:Unrecognised qualifier handled inconsistently, so hand-backs skip --no-pc;Showing an item whose PC-only status is unknown errs toward visibility, its qualifier text stays visible to the session, and quest trees cannot hold it because `quest check` rejects it (src/core/rules.ts:255).src/cli/main.ts:512:--no-pc changes maintainer-first ordering;The ordering is intended and tested, and the `waiting` help at src/cli/main.ts:501 now says both filters apply before ranking, so order follows the items kept.Waiting
quest wait's rule thatchecks:passedfires only once every check is idle, and to merge as is. Reasons are under "Choices made without asking".Maintainer decisioncomment; the next/quest-iteraterecords it and reruns/quest-review.quest waitin this PR, which needs Kixel Quest index parity.Maintainer decisioncomment answers it.