Skip to content

fix: the nightly macOS check compiles again - #224

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/nightly-macos-check
Nov 21, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/nightly-macos-check

Conversation

@kixelated

@kixelated kixelated commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The nightly workflow's macOS job (just ci on macos-latest) failed every night since 2026-11-19 on four compile errors no Linux check sees. This fixes both causes and finishes quest/m0/nightly-macos-check.md, deleting it.

  • rs/moq-scene/src/browser/mach.rs, the Mach rendezvous test: IOSurfaceRef::id sits behind objc2-io-surface's IOSurfaceTypes feature, which nothing turns on. rs/moq-scene/Cargo.toml now names it in the macOS dev-dependencies, the only reader.
  • rs/moq-studio/src/controls.rs: Fixed::id and Action::id have one consumer, Wayland's GlobalShortcuts portal (hotkeys/portal.rs), so they are dead code on macOS (and Windows) under -D warnings. They now expect(dead_code) off Linux outside tests, the same gate hotkeys::Reach already uses for the portal-only variants.

Public API and wire: none (a private struct, a crate-private binary method, and a dev-dependency feature).

Decisions

  • The quest's Plan guessed IOSurfaceTypes used to be turned on by something else in the graph and asked to find the Cargo.lock change. It was never on: the test arrived with the method call in moq-dev/studio#206, and the 2026-11-19 nightly (before feat: browser sources on macOS #206) failed on only the controls.rs errors. So there is no lockfile change to chase.
  • Gated id off Linux rather than giving it a macOS consumer: macOS's native hotkeys (RegisterEventHotKey) bind keys directly and have no desktop settings to key an id under, so a consumer there would be invented work.

Caused by

  • moq-dev/studio#207 - added Fixed::id and Action::id read only by the Linux portal, dead code on macOS (found by check: nightly macOS)
  • moq-dev/studio#206 - its Mach test calls IOSurfaceRef::id without the IOSurfaceTypes feature (found by check: nightly macOS)

Validation

  • Reproduced from Linux: cargo clippy --locked --workspace --all-targets --target aarch64-apple-darwin --features moq-scene/capture,moq-studio/capture,moq-studio/openh264 -- -D warnings with the 1.98.1 toolchain's Apple std and a stub C compiler (clippy links nothing; openh264-sys2 only needs objects to exist). On main it fails with exactly the nightly's four errors; with this change it passes. cef is left out of that run because cef-dll-sys needs the macOS CEF distribution; mach.rs is not behind cef.
  • just ci on Linux passes.
  • Nightly dispatched on this branch: run 44892800254 at 3464779 passed every job, the macOS just ci included.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 3464779

  • Base: origin/main at 9291483

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1fdc1-b82d-7fd2-b660-74397e953c51, round 1

  • Score: 9/10, The source changes are sound and preserve runtime behavior, but macOS validation remains unverified because builds and tests were not run as instructed.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a1fdc1-b82d-7022-9b35-00560d1243af, round 1

  • Score: 9/10, The changes narrowly enable the macOS test's required IOSurface feature and acknowledge shortcut identifiers unused outside Linux, with no actionable defects found by source review; builds and tests were not run.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 21, 2026 02:00
The Mach rendezvous test reads IOSurface IDs, which objc2-io-surface keeps
behind its IOSurfaceTypes feature, and only Linux's portal reads an action's
desktop id, so macOS's -D warnings failed on it as dead code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Nightly macOS check passes again fix: the nightly macOS check compiles again Nov 21, 2026
@kixelated
kixelated marked this pull request as ready for review November 21, 2026 10:58
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The macOS development dependencies add objc2-io-surface with the IOSurfaceTypes feature. Fixed.id and Action::id gain conditional dead-code lint expectations for non-Linux, non-test builds. The nightly macOS check document is removed. These changes do not alter runtime behavior or public API signatures.

Merge Risk: Minimal · up to 37667

This change only fixes macOS CI compile errors by enabling a dev-dependency feature and silencing dead-code warnings on non-Linux builds. It does not change runtime behavior, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix: the nightly macOS check compiles again" matches the main change: it fixes four macOS-only compile errors in the nightly job. The changeset adds the IOSurfaceTypes feature to the macOS …
Description check Passed The description states the failing nightly macOS job, lists the two causes, and maps each cause to the files changed: rs/moq-scene/Cargo.toml for the IOSurfaceTypes feature and rs/moq-studio/src/contr…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix: the nightly macOS check compiles again" matches the main change: it fixes four macOS-only compile errors in the nightly job. The changeset adds the IOSurfaceTypes feature to the macOS dev-dependencies and gates Fixed::id and Action::id dead-code warnings off Linux. The title names the goal and the context, so a teammate scanning history can tell what changed. It does not name the specific causes, which is acceptable.

Full details: Description check

Explanation

The description states the failing nightly macOS job, lists the two causes, and maps each cause to the files changed: rs/moq-scene/Cargo.toml for the IOSurfaceTypes feature and rs/moq-studio/src/controls.rs for the dead-code expectations. It also covers the deleted quest file, validation steps, and the related PRs. It is closely tied to the changeset.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution failed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5851915f-4962-4eb2-a315-3ea5274c2f3e
Commits

Reviewing files that changed from the base of the PR and between 66c027f and 37667bb.

Files selected for processing: 3

  • quest/m0/nightly-macos-check.md
  • rs/moq-scene/Cargo.toml
  • rs/moq-studio/src/controls.rs
Files with no reviewable changes: 1

  • quest/m0/nightly-macos-check.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — enables the missing feature where it is read and gates the portal-only ids to the platform that consumes them.

Reviewed changes

  • objc2-io-surface dev-dependency: names IOSurfaceTypes in the macOS dev-dependencies so the Mach test's IOSurfaceRef::id compiles.
  • dead_code gate on id: Fixed::id and Action::id carry expect(dead_code) off Linux outside tests, matching the portal-only gating already used elsewhere.
  • Quest file removed: quest/m0/nightly-macos-check.md is deleted now the work is done.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated enabled auto-merge (squash) November 21, 2026 15:16
@kixelated
kixelated merged commit 1b78cd2 into main Nov 21, 2026
4 checks passed
@kixelated
kixelated deleted the quest/m0/nightly-macos-check branch November 21, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant