Repository navigation
fix: the nightly macOS check compiles again - #224
Conversation
Quest-Claim: c11b73a8ad4bb437
The Mach rendezvous test reads IOSurface IDs, which objc2-io-surface keeps behind its IOSurfaceTypes feature, and only Linux's portal reads an action's desktop id, so macOS's -D warnings failed on it as dead code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe macOS development dependencies add Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — enables the missing feature where it is read and gates the portal-only ids to the platform that consumes them.
Reviewed changes
objc2-io-surfacedev-dependency: namesIOSurfaceTypesin the macOS dev-dependencies so the Mach test'sIOSurfaceRef::idcompiles.dead_codegate onid:Fixed::idandAction::idcarryexpect(dead_code)off Linux outside tests, matching the portal-only gating already used elsewhere.- Quest file removed:
quest/m0/nightly-macos-check.mdis deleted now the work is done.
claude-sonnet-5-5 | 𝕏

The nightly workflow's macOS job (
just cionmacos-latest) failed every night since 2026-11-19 on four compile errors no Linux check sees. This fixes both causes and finishes quest/m0/nightly-macos-check.md, deleting it.rs/moq-scene/src/browser/mach.rs, the Mach rendezvous test:IOSurfaceRef::idsits behindobjc2-io-surface'sIOSurfaceTypesfeature, which nothing turns on.rs/moq-scene/Cargo.tomlnow names it in the macOS dev-dependencies, the only reader.rs/moq-studio/src/controls.rs:Fixed::idandAction::idhave one consumer, Wayland's GlobalShortcuts portal (hotkeys/portal.rs), so they are dead code on macOS (and Windows) under-D warnings. They nowexpect(dead_code)off Linux outside tests, the same gatehotkeys::Reachalready uses for the portal-only variants.Public API and wire: none (a private struct, a crate-private binary method, and a dev-dependency feature).
Decisions
IOSurfaceTypesused to be turned on by something else in the graph and asked to find theCargo.lockchange. It was never on: the test arrived with the method call in moq-dev/studio#206, and the 2026-11-19 nightly (before feat: browser sources on macOS #206) failed on only thecontrols.rserrors. So there is no lockfile change to chase.idoff Linux rather than giving it a macOS consumer: macOS's native hotkeys (RegisterEventHotKey) bind keys directly and have no desktop settings to key an id under, so a consumer there would be invented work.Caused by
Fixed::idandAction::idread only by the Linux portal, dead code on macOS (found by check: nightly macOS)IOSurfaceRef::idwithout theIOSurfaceTypesfeature (found by check: nightly macOS)Validation
cargo clippy --locked --workspace --all-targets --target aarch64-apple-darwin --features moq-scene/capture,moq-studio/capture,moq-studio/openh264 -- -D warningswith the 1.98.1 toolchain's Apple std and a stub C compiler (clippy links nothing;openh264-sys2only needs objects to exist). Onmainit fails with exactly the nightly's four errors; with this change it passes.cefis left out of that run becausecef-dll-sysneeds the macOS CEF distribution;mach.rsis not behindcef.just cion Linux passes.just ciincluded.Models
Size: S
Implementer: Claude Code, claude-opus-5-5, unknown effort (arm A)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: 3464779
Base: origin/main at 9291483
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1fdc1-b82d-7fd2-b660-74397e953c51, round 1Score: 9/10,
The source changes are sound and preserve runtime behavior, but macOS validation remains unverified because builds and tests were not run as instructed.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1fdc1-b82d-7022-9b35-00560d1243af, round 1Score: 9/10,
The changes narrowly enable the macOS test's required IOSurface feature and acknowledge shortcut identifiers unused outside Linux, with no actionable defects found by source review; builds and tests were not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none