Skip to content

quest: picked displays and windows restore on GNOME - #227

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/wayland-picker-check
Nov 22, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/wayland-picker-check

Conversation

@kixelated

@kixelated kixelated commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Finishes quest/m0/wayland-picker-check.md: picked displays and windows reopen across restarts without the desktop's picker on a desktop that keeps grants.

Summary

Deletes the quest. Its Goal is met: the maintainer ran its check on a real GNOME Wayland session.

Validation

On fedora (Fedora, GNOME on Wayland, xdg-desktop-portal-gnome), main at 1b78cd2 built with --features capture,pipewire,vaapi, opened on an empty scene file:

Check Result
First add of Picked display and Picked window shows GNOME's picker, and each shows what was picked Pass (window content unconfirmed, see below)
~/.local/state/moq-studio/portal.toml holds one grant per source under the scene file's path, mode 0600 Pass
A restart reopens both with no picker Pass, three restarts; both PipeWire captures opened within 4 ms of startup
Removing a source drops its grant (a second picked display, added and removed) Pass
Stopping sharing from GNOME's indicator fails the source and drops its grant, and Reload shows the picker again Not run: the maintainer signed off without it

Both captures logged kind=Screen at 2560x1440, the window included. That fits a maximized window; whether the window source drew only its window was not confirmed separately.

No code changed; the public API and wire are untouched.

Follow-ups

None.

Models

Size: XS
Implementer: Claude, claude-opus-5-5, unknown effort

Review

Rewritten by quest review after each round.

  • Head: 6f6aa2c

  • Base: origin/main at 1b78cd2

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a200c0-4a36-7280-9dde-6e03807a42e2, round 1

  • Score: 10/10, The change only removes the completed Wayland picker verification quest, with no runtime changes, remaining references, or actionable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a200c0-4a36-7193-9a2d-76153447d99f, round 1

  • Score: 10/10, The change only removes a manual-verification quest, does not alter runtime behavior, and has no actionable findings.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

kixelated and others added 2 commits November 21, 2026 16:54
The maintainer ran the check on a GNOME Wayland session: both sources
reopen across restarts without the portal's picker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Picked displays and windows are tried on a Wayland desktop quest: picked displays and windows restore on GNOME Nov 22, 2026
@kixelated
kixelated marked this pull request as ready for review November 22, 2026 00:55
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Wayland picker check quest was deleted. It described manual checks for display and window selection, grant persistence across studio restarts, and grant removal after sharing stops.

Merge Risk: Minimal · up to 6f6aa

This pull request removes a completed manual check document and does not change runtime behavior. There is no concrete merge risk from the change itself.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: picked displays and windows restore on GNOME without the desktop picker. The changeset deletes the quest file whose goal was met, and the PR objectives describe that s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description matches the changeset. It states that the Wayland picker quest at quest/m0/wayland-picker-check.md is finished and deleted, and it reports the GNOME Wayland validation results that jus…
Full details: Title check

Explanation

The title names the main change: picked displays and windows restore on GNOME without the desktop picker. The changeset deletes the quest file whose goal was met, and the PR objectives describe that same verification. The title is specific and matches the changeset's purpose, so it passes.

Full details: Description check

Explanation

The description matches the changeset. It states that the Wayland picker quest at quest/m0/wayland-picker-check.md is finished and deleted, and it reports the GNOME Wayland validation results that justify the removal. It also states that no code changed, which fits the raw summary showing a 36-line deletion of a single markdown file with no declaration changes.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fb923925-1860-472b-951c-8ae177c12826
Commits

Reviewing files that changed from the base of the PR and between 1b78cd2 and 6f6aa2c.

Files selected for processing: 1

  • quest/m0/wayland-picker-check.md
Files with no reviewable changes: 1

  • quest/m0/wayland-picker-check.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — deletes a manual-verification quest whose Goal the PR body reports as met on a real GNOME Wayland session.

Reviewed changes

The whole diff, one file removed.

  • Quest removal: deletes quest/m0/wayland-picker-check.md. No code changes, and no other references to the file remain in the repo.

The stop-sharing check was not run, and the PR body says so. The maintainer accepted that.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

@kixelated
kixelated enabled auto-merge (squash) November 22, 2026 01:00
@kixelated
kixelated merged commit 99ec125 into main Nov 22, 2026
5 checks passed
@kixelated
kixelated deleted the quest/m0/wayland-picker-check branch November 22, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant