Repository navigation
feat: send settings.multiFrame on job submit - #1
Merged
Merged
Conversation
Vendor the current Nexrender API spec, which adds settings.multiFrame to job, nested job and join job settings, and regenerate the client. Before this, job submit parsed the file into a struct without the field and silently dropped it. The spec sync also picks up updated descriptions for asset and template sources and S3 endpoints, and maxLength on two fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves the conflicts with the CLI changes merged since: the vendored OpenAPI spec is synced again from nexrender-api dev, which now carries settings.multiFrame together with the template.src, batch retry and join minimum changes, and the client is regenerated from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job submitparses the job file into the generatedapi.JobCreationstruct and sends that. The vendored spec didn't havesettings.multiFrame, so the CLI silently dropped it:{"settings":{"multiFrame":false}}went out as{"settings":{}}.openapi/openapi.jsonsynced from nexrender-apidev(nexrender/nexrender-api#180), andinternal/api/api.gen.goregenerated. That addsMultiFrame *boolto job, nested job and join job settings. The sync also picks up newer descriptions for asset and template sources and S3 endpoints, andmaxLengthon two fields.references/operations.mdon when to setsettings.multiFrame.TestJobPayloadKeepsMultiFramechecks thattrueandfalsesurvive into the submitted payload and that the field stays out when not set. It fails against the old generated client.Testing
go generate,gofmt,go test ./...,go vet ./...,go build,bash -n scripts/install.shall pass.multiFramefalse/true/ unset. They rendered in 40 s / 20 s / 20 s (aerender time).🤖 Generated with Claude Code