Repository navigation
Vanguard: Accept short codec names - #2
Merged
Merged
Conversation
The CLI rejected any codec without a video_ or image_ prefix, but the API matches codecs by suffix and the OpenAPI spec itself gives short examples (h264_vbr_15mbps, prores_422, png, jpeg). Production traffic uses short names such as png and h264_vbr_5mbps, so those payloads could not be submitted through the CLI. The client-side prefix rule is gone. The API still rejects unknown codecs and returns the supported list. The agent skill now documents both forms. Found by Vanguard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nexrender job submitandbatch submitrejected anysettings.codecwithout avideo_orimage_prefix:codec "png" is missing its output prefix. The API does not need the prefix:resolveCodecmatches codecs by suffix, sopng,h264_vbr_5mbps,prores_4444andgifare all valid.'h264_vbr_15mbps', 'prores_422', 'png', 'jpeg'.png96,h264_vbr_5mbps46).The prefix rule in
internal/validateis removed. Codec validation is left to the API, which rejects unknown codecs with the list of supported ones. The agent skill reference now says both forms work.This repository only has
main, so the PR targets it.Found by Vanguard, the new end-to-end suite.
Testing
go test ./...,go vet ./...,go build ./cmd/nexrender,gofmt -l(clean),bash -n scripts/install.sh.png,jpeg,h264_vbr_5mbps,prores_4444,gif,image_pngandvideo_h264_vbr_15mbps.