Repository navigation
Conditional questions: base implementation plus support for radio and dropdown triggers #3833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndyScherzinger
wants to merge
38
commits into
main
Choose a base branch
from
feat/conditional-questions-1-base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,013
−535
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
0096a5d
Feat: Conditional Logic
mickenordin dc9bf99
fix: allow empty branches, fixes
timedin-de 53969d4
fix: trigger question options
timedin-de 4c5e651
fix: show conditional answers in detail view
timedin-de 3a0d42c
fix: save options and extraSettings for subquestions
timedin-de 3be7668
fix: move up/down for subquestions
timedin-de dc3dce2
feat: add ranking-question to conditional
timedin-de 7fe2f70
fix: multiple active branches
timedin-de 56ca86c
fix: selectors for linear scale
timedin-de 664edda
fix: extract question list to seperate component, add 'insert questio…
timedin-de 3bb2dd5
feat: adding transition to conditional branches
timedin-de 803d7e3
fix: harden conditional submission handling
mickenordin ae80c43
fix: selectors for linear scale
timedin-de 8431f7b
fix: use constants instead of raw strings
timedin-de 49982e8
fix: cloning forms
timedin-de d3a0fc0
fix: tests
timedin-de 81acec6
fix: backend support for multiple active branches
timedin-de bc129fd
fix: conditional branch test mock and psalm types
mickenordin be331ea
fix: align conditional question view types
mickenordin c751406
test: cover upload authorization for conditional answers
mickenordin 021429d
fix: use valid template syntax for answer updates
mickenordin 0fc43fd
fix: avoid persisting conditional subquestions twice
mickenordin 7149fe6
fix: simplify conditional trigger type selection
mickenordin e5e3cdd
fix(conditional): keep subquestions in their place on question updates
AndyScherzinger 9e00375
fix(conditional): keep branches, order and copies of subquestions con…
AndyScherzinger bfe6a64
fix(conditional): validate and store trigger answers like regular que…
AndyScherzinger ed43068
fix(conditional): number and label subquestions apart from other ques…
AndyScherzinger 44379c7
fix(conditional): match conditions the same way in the browser and on…
AndyScherzinger ed32b7e
fix(conditional): summarize subquestions and keep the trigger menu to…
AndyScherzinger 8a69cc8
test(e2e): cover answering a conditional question
AndyScherzinger 82c43c8
chore(conditional): name the migration after the 5.5 release
AndyScherzinger f5fbdc7
fix(conditional): indent subquestions less on phones
AndyScherzinger 33fef4f
docs(conditional): list the condition types the server accepts
AndyScherzinger 0cff919
feat(conditional): start with radio button and dropdown triggers
AndyScherzinger 6c6cc98
test(conditional): cover reordering subquestions and loading them
AndyScherzinger d2dbfac
fix(submission): only accept question and option ids as they are
AndyScherzinger 60bcfca
fix(migration): skip answers of deleted questions on import
AndyScherzinger 21f29c0
fix(a11y): focus the title of new questions of every type
AndyScherzinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems to be wrong with this addition here, probably misplaced after a rebase?