Skip to content

lookup: allow scripts entries to be conditionally skipped - #1191

Open
ljharb wants to merge 1 commit into
mainfrom
lookup-scripts-skip
Open

ljharb wants to merge 1 commit into
mainfrom
lookup-scripts-skip

Conversation

@ljharb

@ljharb ljharb commented Oct 8, 2026

Copy link
Copy Markdown
Member

Entries in a module's scripts array may now be an object of the form { "script": "name", "skip": <condition> },
where skip accepts the same conditions as the top-level skip. Use this to skip posttest for resolve on win32.

ref #1182 (comment)

Entries in a module's `scripts` array may now be an object of the form
`{ "script": "name", "skip": <condition> }`,
where `skip` accepts the same conditions as the top-level `skip`.
Use this to skip `posttest` for `resolve` on win32.
@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (147e8d8) to head (9fd5704).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   96.11%   96.15%   +0.03%     
==========================================
  Files          29       29              
  Lines        2213     2235      +22     
==========================================
+ Hits         2127     2149      +22     
  Misses         86       86              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BethGriggs

Copy link
Copy Markdown
Member

I’m somewhat neutral on this as I am thinking about how often it would be used. Adding more mechanisms to skip tests adds complexity to understanding what’s being run and where. Do we think it’s worthwhile, even if it was just used for resolve? Just thinking it through.

@ljharb

ljharb commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

The way I think about it is, this maximizes test coverage while still allowing skips - otherwise, the script is skipped needlessly on N platforms when it only needs to be skipped on 1.

@ljharb
ljharb force-pushed the lookup-scripts-skip branch from b95c40c to 9fd5704 Compare November 2, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants