Repository navigation
build,test: setup perfetto tests on windows build - #66731
Open
legendecas wants to merge 3 commits into
Open
legendecas wants to merge 3 commits into
legendecas wants to merge 3 commits into
Conversation
nodejs-github-bot
added
build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66731 +/- ##
==========================================
- Coverage 90.59% 90.58% -0.02%
==========================================
Files 797 797
Lines 278475 278475
Branches 53533 53534 +1
==========================================
- Hits 252293 252253 -40
- Misses 16532 16567 +35
- Partials 9650 9655 +5 🚀 New features to boost your workflow:
|
legendecas
force-pushed
the
perfetto-win
branch
from
October 14, 2026 18:08
49957c9 to
cda8a37
Compare
legendecas
changed the title
aduh95
reviewed
Oct 15, 2026
|
|
||
| def main(): | ||
| exe = 'trace_processor_shell.exe' if is_windows else 'trace_processor_shell' | ||
| trace_processor = sys.argv[1] if len(sys.argv) > 1 else os.path.join(script_dir, exe) |
Contributor
There was a problem hiding this comment.
Shouldn't we be using resolve from the pwd instead of join to the script_dir?
Member
Author
There was a problem hiding this comment.
os.path.join(script_dir, exe) is the default path when no args given, it's the fixed path <workspace>/tools/perfetto/trace_processor_shell[.exe, irrelevant to cwd.
Member
Author
|
I will rebase this when #66876 lands. |
Original commit message:
[tracing] do not define legacy tracing classes when using Perfetto
Otherwise the Windows build of Node.js fails with `undefined symbol`
errors due to the missing destructor.
Change-Id: Id0841aed2f0a8f0cfe8889c39150552e31ee5f96
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8580049
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Chengzhong Wu <cwu631@bloomberg.net>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Cr-Commit-Position: refs/heads/main@{#110947}
Refs: v8/v8@785a2ea
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
legendecas
force-pushed
the
perfetto-win
branch
from
October 22, 2026 13:55
cda8a37 to
44af167
Compare
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
force-pushed
the
perfetto-win
branch
from
October 22, 2026 14:01
44af167 to
ad39bf5
Compare
aduh95
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the
trace_processor_shellscript to a python script so that itcan be ran on Windows as well. This also adds a flag
with-perfettoinvcbuild.batto build Node.js with perfetto support.