Skip to content

test: fix test-config-json-schema - #66891

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-test-config-json-schema
Closed

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-test-config-json-schema

Conversation

@aduh95

@aduh95 aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please πŸ‘ to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 21, 2026
@aduh95

aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Actually, it doesn't really make sense, the test should be disabled when QUIC is enabled – given that it's disabled by default. The QUIC job should skip this test on main yet it doesn't πŸ€” in any case, that PR won't help

@aduh95 aduh95 closed this Oct 21, 2026
@aduh95
aduh95 deleted the fix-test-config-json-schema branch October 21, 2026 09:21
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.50%. Comparing base (796a83a) to head (aae4796).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66891      +/-   ##
==========================================
- Coverage   90.59%   90.50%   -0.10%     
==========================================
  Files         797      797              
  Lines      278362   278362              
  Branches    53505    53496       -9     
==========================================
- Hits       252195   251930     -265     
- Misses      16521    16807     +286     
+ Partials     9646     9625      -21     

see 42 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants